infra/bots/flavor/valgrind_flavor.py - Issue 1827413002: Fixes for Swarming recipes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra/bots/flavor/valgrind_flavor.py

Issue 1827413002: Fixes for Swarming recipes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Reinstate tmp_dir Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 #!/usr/bin/env python

2 #

3 # Copyright 2016 Google Inc.

4 #

5 # Use of this source code is governed by a BSD-style license that can be

6 # found in the LICENSE file.

7

8

9 import default_flavor

10 import os

11

12

13 """Utils for running under Valgrind."""

14

15

16 class ValgrindFlavorUtils(default_flavor.DefaultFlavorUtils):

17 def __init__(self, args, *kwargs):

18 super(ValgrindFlavorUtils, self).__init__(args, *kwargs)

19 self._suppressions_file = os.path.join(self._bot_info.skia_dir,

20 'tools', 'valgrind.supp')

21

22 def step(self, name, cmd, **kwargs):

23 new_cmd = ['valgrind', '--gen-suppressions=all', '--leak-check=full',

24 '--track-origins=yes', '--error-exitcode=1', '--num-callers=40',

25 '--suppressions=%s' % self._suppressions_file]

26 path_to_app = os.path.join(self._bot_info.out_dir,

27 self._bot_info.configuration, cmd[0])

28 new_cmd.append(path_to_app)

29 new_cmd.extend(cmd[1:])

30 return self._bot_info.run(new_cmd, **kwargs)

31

OLD	NEW