Add logic for git 2.7.4 upgrade.

Add logic for git 2.7.4 upgrade.

R=dnj@chromium.org, mmoss@chromium.org, vadimsh@chromium.org
BUG=595883
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299520

[iannucci, 2016-03-26 10:48:57]

Not tried yet, but if someone feels like looking at batchfiles, this is the one
to look at :p

[Michael Moss, 2016-03-28 23:02:03]

lgtm

[iannucci, 2016-03-29 00:06:37]

OK, made a bunch of changes to make it actually work. PTAL

[dnj, 2016-03-29 00:08:07]

dnj@chromium.org changed reviewers:
+ dnj@chromium.org

[dnj, 2016-03-29 00:08:08]

https://chromiumcodereview.appspot.com/1827403003/diff/80001/bootstrap/win/wi...
File bootstrap/win/win_tools.bat (right):

https://chromiumcodereview.appspot.com/1827403003/diff/80001/bootstrap/win/wi...
bootstrap/win/win_tools.bat:67: :: Check to see if we're on a 32 or 64 bit
system
Can we standardize on "rem" comments, given the issues you encountered with
label comments?

https://chromiumcodereview.appspot.com/1827403003/diff/80001/bootstrap/win/wi...
bootstrap/win/win_tools.bat:73: set
GIT_FETCH_URL=https://commondatastorage.googleapis.com/chrome-infra/PortableGit-%GIT_VERSION%-bit.7z.exe
Windows Git works on 32- and 64-bit? Is there a 64-bit distro?

[iannucci, 2016-03-29 00:11:12]

https://chromiumcodereview.appspot.com/1827403003/diff/80001/bootstrap/win/wi...
File bootstrap/win/win_tools.bat (right):

https://chromiumcodereview.appspot.com/1827403003/diff/80001/bootstrap/win/wi...
bootstrap/win/win_tools.bat:67: :: Check to see if we're on a 32 or 64 bit
system
On 2016/03/29 at 00:08:07, dnj wrote:
> Can we standardize on "rem" comments, given the issues you encountered with
label comments?

Rather not: they're quite hard to read. This file should go away with cipd
soonish anyway.

https://chromiumcodereview.appspot.com/1827403003/diff/80001/bootstrap/win/wi...
bootstrap/win/win_tools.bat:73: set
GIT_FETCH_URL=https://commondatastorage.googleapis.com/chrome-infra/PortableGit-%GIT_VERSION%-bit.7z.exe
What? We use %OS_BITS% on the previous line.

https://chromiumcodereview.appspot.com/1827403003/diff/100001/bootstrap/win/w...
File bootstrap/win/win_tools.bat (right):

https://chromiumcodereview.appspot.com/1827403003/diff/100001/bootstrap/win/w...
bootstrap/win/win_tools.bat:70: if not exist
"%WIN_TOOLS_ROOT_DIR%\.git_bleeding_edge" goto :GIT_OLD_FLOW
can't use code blocks here, because we can't rely on setlocal delayed variable
expansion: TL;DR: variables set within the block are not usable within that
block, and so things like GIT_VERSION being show up as empty when expanded into
e.g. GIT_FETCH_URL.

[dnj, 2016-03-29 00:17:37]

lgtm

https://chromiumcodereview.appspot.com/1827403003/diff/80001/bootstrap/win/wi...
File bootstrap/win/win_tools.bat (right):

https://chromiumcodereview.appspot.com/1827403003/diff/80001/bootstrap/win/wi...
bootstrap/win/win_tools.bat:67: :: Check to see if we're on a 32 or 64 bit
system
On 2016/03/29 00:11:12, iannucci wrote:
> On 2016/03/29 at 00:08:07, dnj wrote:
> > Can we standardize on "rem" comments, given the issues you encountered with
> label comments?
> 
> Rather not: they're quite hard to read. This file should go away with cipd
> soonish anyway.

Acknowledged.

https://chromiumcodereview.appspot.com/1827403003/diff/80001/bootstrap/win/wi...
bootstrap/win/win_tools.bat:73: set
GIT_FETCH_URL=https://commondatastorage.googleapis.com/chrome-infra/PortableGit-%GIT_VERSION%-bit.7z.exe
On 2016/03/29 00:11:12, iannucci wrote:
> What? We use %OS_BITS% on the previous line.

Oh d'oh missed that.

[iannucci, 2016-03-29 00:41:48]

Description was changed from

==========
Add logic for git 2.7.4 upgrade.

R=mmoss@chromium.org, vadimsh@chromium.org
BUG=595883
==========

to

==========
Add logic for git 2.7.4 upgrade.

R=dnj@chromium.org, mmoss@chromium.org, vadimsh@chromium.org
BUG=595883

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299520
==========

[iannucci, 2016-03-29 00:41:50]

Committed patchset #6 (id:100001) manually as 299520.

[Michael Moss, 2016-03-29 19:34:48]

FWIW, https://github.com/blog/2131-git-2-8-has-been-released

With some Windows-specific improvements :(

[iannucci1, 2016-03-29 19:37:23]

On 2016/03/29 19:34:48, Michael Moss wrote:
> FWIW, https://github.com/blog/2131-git-2-8-has-been-released
> 
> With some Windows-specific improvements :(

Haha yeah I know, but upgrading to that from 2.7.4 should be cake with the new
upgrade flow. After the 2.7.4 upgrade I'll update the code to not have the
old-flow stuff, and then add 2.8 as bleeding edge. We can give it a bit of time
to bake before making it the current version too.