Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 182733010: Keep text position locally in SVGTextMetricsBuilder::measureTextRenderer (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Keep text position locally in SVGTextMetricsBuilder::measureTextRenderer Passing m_textPosition as an argument to the various helper methods allows it to be removed from SVGTextMetricsBuilder and stored on the stack of measureTextRenderer. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M Source/core/rendering/svg/SVGTextMetricsBuilder.h View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.cpp View 6 chunks +20 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
fs
(Maybe not the most obvious improvement, but the next CL in this series - which ...
6 years, 9 months ago (2014-03-05 17:05:01 UTC) #1
Stephen Chennney
Someone else broke the Android build. LGTM
6 years, 9 months ago (2014-03-05 18:08:01 UTC) #2
Stephen Chennney
The CQ bit was checked by schenney@chromium.org
6 years, 9 months ago (2014-03-05 18:08:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/182733010/1
6 years, 9 months ago (2014-03-05 18:08:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/182733010/1
6 years, 9 months ago (2014-03-05 21:00:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 02:42:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-06 02:42:32 UTC) #7
fs
The CQ bit was checked by fs@opera.com
6 years, 9 months ago (2014-03-06 09:13:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/182733010/1
6 years, 9 months ago (2014-03-06 09:13:29 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 10:33:02 UTC) #10
Message was sent while issue was closed.
Change committed as 168618

Powered by Google App Engine
This is Rietveld 408576698