Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Unified Diff: Source/core/rendering/svg/SVGTextMetricsBuilder.h

Issue 182733010: Keep text position locally in SVGTextMetricsBuilder::measureTextRenderer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/rendering/svg/SVGTextMetricsBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/svg/SVGTextMetricsBuilder.h
diff --git a/Source/core/rendering/svg/SVGTextMetricsBuilder.h b/Source/core/rendering/svg/SVGTextMetricsBuilder.h
index 708f10323f7f836727a34833881a409242230c9d..0ad2710c0b3a30ac0fda96830e46c2d2ce89c962 100644
--- a/Source/core/rendering/svg/SVGTextMetricsBuilder.h
+++ b/Source/core/rendering/svg/SVGTextMetricsBuilder.h
@@ -41,10 +41,10 @@ public:
void buildMetricsAndLayoutAttributes(RenderSVGText*, RenderSVGInlineText* stopAtLeaf, SVGCharacterDataMap& allCharactersMap);
private:
- SVGTextMetrics computeMetricsForCurrentCharacter();
- SVGTextMetrics computeMetricsForCurrentCharacterSimple();
- SVGTextMetrics computeMetricsForCurrentCharacterComplex();
- bool currentCharacterStartsSurrogatePair() const;
+ SVGTextMetrics computeMetricsForCurrentCharacter(unsigned textPosition);
+ SVGTextMetrics computeMetricsForCurrentCharacterSimple(unsigned textPosition);
+ SVGTextMetrics computeMetricsForCurrentCharacterComplex(unsigned textPosition);
+ bool currentCharacterStartsSurrogatePair(unsigned textPosition) const;
void initializeMeasurementWithTextRenderer(RenderSVGInlineText*);
void walkTree(RenderObject*, RenderSVGInlineText* stopAtLeaf, MeasureTextData*);
@@ -52,7 +52,6 @@ private:
RenderSVGInlineText* m_text;
TextRun m_run;
- unsigned m_textPosition;
bool m_isComplexText;
float m_totalWidth;
« no previous file with comments | « no previous file | Source/core/rendering/svg/SVGTextMetricsBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698