Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1827303002: Report and parse .img, .iso, and .smi as DMGs when downloading (Closed)

Created:
4 years, 9 months ago by Nathan Parker
Modified:
4 years, 9 months ago
Reviewers:
asanka, holte, Steven Holte
CC:
asvitkine+watch_chromium.org, chromium-reviews, grt+watch_chromium.org, Robert Sesek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report and parse .img, .iso, and .smi as DMGs when downloading These files are all opened by Disk Utility. 70% of this patch was written by research@nightwatchcybersecurity.com BUG=596354 Committed: https://crrev.com/74ab4f95a557f6cfb425555a0c7021e80d9319dc Cr-Commit-Position: refs/heads/master@{#383277}

Patch Set 1 : nit to histograms #

Patch Set 2 : Fix namespacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -4 lines) Patch
M chrome/browser/safe_browsing/download_protection_service.cc View 1 3 chunks +29 lines, -4 lines 0 comments Download
M chrome/common/safe_browsing/download_protection_util.cc View 4 chunks +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Nathan Parker
asanka: Please review dowload_protection changes holte: Please review histograms.xml Thanks!
4 years, 9 months ago (2016-03-25 00:39:23 UTC) #5
asanka
lgtm
4 years, 9 months ago (2016-03-25 02:01:43 UTC) #7
Steven Holte
lgtm
4 years, 9 months ago (2016-03-25 02:02:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827303002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827303002/80001
4 years, 9 months ago (2016-03-25 15:54:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 9 months ago (2016-03-25 16:15:18 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 16:16:49 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74ab4f95a557f6cfb425555a0c7021e80d9319dc
Cr-Commit-Position: refs/heads/master@{#383277}

Powered by Google App Engine
This is Rietveld 408576698