Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1827303002: Report and parse .img, .iso, and .smi as DMGs when downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix namespacing Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/common/safe_browsing/download_protection_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 15640b6d239fa3822485a1180c683604fbe932d7..ca4ebdd669d2b6897716edab9215db064be7c76b 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -43762,16 +43762,49 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="SBClientDownload.DmgFileFailureByType"
+ enum="SBClientDownloadExtensions">
+ <owner>nparker@chromium.org</owner>
+ <summary>
+ Counts of DMG-like file types that failed to be successfully analyzed by the
+ SafeBrowsing download service.
+ </summary>
+</histogram>
+
<histogram name="SBClientDownload.DmgFileHasExecutable" enum="Boolean">
<owner>rsesek@chromium.org</owner>
+ <obsolete>
+ Replaced by SBClientDownload.DmgFileHas[No]ExecutableByType in M51.
+ </obsolete>
<summary>
For each DMG file analyzed by the SafeBrowsing download service, records if
the DMG contained an executable file.
</summary>
</histogram>
+<histogram name="SBClientDownload.DmgFileHasExecutableByType"
+ enum="SBClientDownloadExtensions">
+ <owner>nparker@chromium.org</owner>
+ <summary>
+ Counts of DMG-like file types which were analyzed by the SafeBrowsing
+ download service that contained an executable file.
+ </summary>
+</histogram>
+
+<histogram name="SBClientDownload.DmgFileHasNoExecutableByType"
+ enum="SBClientDownloadExtensions">
+ <owner>nparker@chromium.org</owner>
+ <summary>
+ Counts of DMG-like file types which were analyzed by the SafeBrowsing
+ download service that did NOT contain an executable file.
+ </summary>
+</histogram>
+
<histogram name="SBClientDownload.DmgFileSuccess" enum="BooleanSuccess">
<owner>rsesek@chromium.org</owner>
+ <obsolete>
+ Replaced by SBClientDownload.DmgFile{Success,Failure}ByType in M51.
+ </obsolete>
<summary>
For each DMG file analyzed by the SafeBrowsing download service, records
true if the analysis was successful, or false if there was an error
@@ -43779,6 +43812,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="SBClientDownload.DmgFileSuccessByType"
+ enum="SBClientDownloadExtensions">
+ <owner>nparker@chromium.org</owner>
+ <summary>
+ Counts of DMG-like file types that were successfully analyzed by the
+ SafeBrowsing download service.
+ </summary>
+</histogram>
+
<histogram name="SBClientDownload.DownloadExtensions"
enum="SBClientDownloadExtensions">
<owner>mattm@chromium.org</owner>
@@ -80295,6 +80337,8 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="244" label="RTF"/>
<int value="245" label="VHDX"/>
<int value="246" label="SEARCH_MS"/>
+ <int value="247" label="IMG"/>
+ <int value="248" label="SMI"/>
</enum>
<enum name="SBClientDownloadIsSignedBinary" type="int">
« no previous file with comments | « chrome/common/safe_browsing/download_protection_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698