Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1827283002: media: Cancel any pending pipeline restart when the player is hidden (Closed)

Created:
4 years, 9 months ago by watk
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

media: Cancel any pending pipeline restart when the player is hidden It's possible for WMPI to get an OnHidden callback while in the middle of a suspend/resume restart. Previously it would continue with the restart, incorrectly resuming after being hidden. Now it will cancel any ongoing restart when receiving OnHidden. BUG=597404 Review URL: https://codereview.chromium.org/1827873003 Cr-Commit-Position: refs/heads/master@{#382964} (cherry picked from commit 01dc013d3ae6e6e1b5a0e34733652b2febabe488) Committed: https://chromium.googlesource.com/chromium/src/+/9a86871643138320e2066ee572bc4acba25c55d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
watk
4 years, 9 months ago (2016-03-24 21:47:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a86871643138320e2066ee572bc4acba25c55d1.

Powered by Google App Engine
This is Rietveld 408576698