Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1827873003: media: Cancel any pending pipeline restart when the player is hidden (Closed)

Created:
4 years, 9 months ago by watk
Modified:
4 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, sandersd (OOO until July 31)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Cancel any pending pipeline restart when the player is hidden It's possible for WMPI to get an OnHidden callback while in the middle of a suspend/resume restart. Previously it would continue with the restart, incorrectly resuming after being hidden. Now it will cancel any ongoing restart when receiving OnHidden. BUG=597404 Committed: https://crrev.com/01dc013d3ae6e6e1b5a0e34733652b2febabe488 Cr-Commit-Position: refs/heads/master@{#382964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
watk
4 years, 9 months ago (2016-03-23 22:09:52 UTC) #2
DaleCurtis
lgtm
4 years, 9 months ago (2016-03-23 22:18:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827873003/1
4 years, 9 months ago (2016-03-23 22:22:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 23:10:48 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 23:12:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01dc013d3ae6e6e1b5a0e34733652b2febabe488
Cr-Commit-Position: refs/heads/master@{#382964}

Powered by Google App Engine
This is Rietveld 408576698