Fix number parsing problems with HttpResponseHeaders::GetAgeValue() to not accept invalid numbers.

Fix number parsing problems with HttpResponseHeaders::GetAgeValue() to not accept invalid numbers.

BUG=596523, 596554
Committed: https://crrev.com/2a545c6ef2899f1218bfd06ee6ff9666a8ff304f
Cr-Commit-Position: refs/heads/master@{#386467}

[eroman, 2016-03-24 21:26:32]

Description was changed from

==========
Fix number parsing problems with HttpResponseHeaders::GetAgeValue().

BUG=596523, 596554
==========

to

==========
Fix number parsing problems with HttpResponseHeaders::GetAgeValue().

It was wrong in several ways:

  (1) Accepted invalid numbers
  (2) Accepted negative numbers
  (3) Could integer overflow when assigning to TimeDelta::FromSeconds() -
because the number of seconds could be INT64_MAX, and FromSeconds() scales to
internal representation.

I suspect the original intent was to do a saturating conversion, so that any age
too large to be parsed would be treated as some big number. (This interpretation
is consistent with RFC 2616).

BUG=596523, 596554
==========

[eroman, 2016-04-08 22:49:33]

Description was changed from

==========
Fix number parsing problems with HttpResponseHeaders::GetAgeValue().

It was wrong in several ways:

  (1) Accepted invalid numbers
  (2) Accepted negative numbers
  (3) Could integer overflow when assigning to TimeDelta::FromSeconds() -
because the number of seconds could be INT64_MAX, and FromSeconds() scales to
internal representation.

I suspect the original intent was to do a saturating conversion, so that any age
too large to be parsed would be treated as some big number. (This interpretation
is consistent with RFC 2616).

BUG=596523, 596554
==========

to

==========
Fix number parsing problems with HttpResponseHeaders::GetAgeValue() to not
accept invalid numbers.

BUG=596523, 596554
==========

[eroman, 2016-04-08 23:00:14]

eroman@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2016-04-11 16:59:08]

LGTM

https://codereview.chromium.org/1827243002/diff/80001/net/http/http_response_...
File net/http/http_response_headers_unittest.cc (right):

https://codereview.chromium.org/1827243002/diff/80001/net/http/http_response_...
net/http/http_response_headers_unittest.cc:560: "Age: -10\n";
Should we have a "0" test?

https://codereview.chromium.org/1827243002/diff/80001/net/http/http_response_...
net/http/http_response_headers_unittest.cc:586: // Should have saturated to 2^32
nit:  +period, -1.

[eroman, 2016-04-11 17:39:25]

https://codereview.chromium.org/1827243002/diff/80001/net/http/http_response_...
File net/http/http_response_headers_unittest.cc (right):

https://codereview.chromium.org/1827243002/diff/80001/net/http/http_response_...
net/http/http_response_headers_unittest.cc:560: "Age: -10\n";
On 2016/04/11 16:59:07, mmenke wrote:
> Should we have a "0" test?

Done.

https://codereview.chromium.org/1827243002/diff/80001/net/http/http_response_...
net/http/http_response_headers_unittest.cc:586: // Should have saturated to 2^32
On 2016/04/11 16:59:07, mmenke wrote:
> nit:  +period, -1.

Done.

[eroman, 2016-04-11 18:52:21]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-04-11 18:52:21]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1827243002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-11 18:53:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827243002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827243002/120001

[commit-bot: I haz the power, 2016-04-11 20:59:15]

Description was changed from

==========
Fix number parsing problems with HttpResponseHeaders::GetAgeValue() to not
accept invalid numbers.

BUG=596523, 596554
==========

to

==========
Fix number parsing problems with HttpResponseHeaders::GetAgeValue() to not
accept invalid numbers.

BUG=596523, 596554
==========

[commit-bot: I haz the power, 2016-04-11 20:59:16]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-11 21:01:00]

Description was changed from

==========
Fix number parsing problems with HttpResponseHeaders::GetAgeValue() to not
accept invalid numbers.

BUG=596523, 596554
==========

to

==========
Fix number parsing problems with HttpResponseHeaders::GetAgeValue() to not
accept invalid numbers.

BUG=596523, 596554

Committed: https://crrev.com/2a545c6ef2899f1218bfd06ee6ff9666a8ff304f
Cr-Commit-Position: refs/heads/master@{#386467}
==========

[commit-bot: I haz the power, 2016-04-11 21:01:01]

Patchset 7 (id:??) landed as
https://crrev.com/2a545c6ef2899f1218bfd06ee6ff9666a8ff304f
Cr-Commit-Position: refs/heads/master@{#386467}