Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: net/http/http_response_headers.h

Issue 1827243002: Fix number parsing problems with HttpResponseHeaders::GetAgeValue() to not accept invalid numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@parse_refactor
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_response_headers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_response_headers.h
diff --git a/net/http/http_response_headers.h b/net/http/http_response_headers.h
index a3126aa72d76c45fa1bc9e69fdec9bab0bf72470..c115bee12dc976bf9fd359a6b47cc6710b8a5619 100644
--- a/net/http/http_response_headers.h
+++ b/net/http/http_response_headers.h
@@ -253,8 +253,8 @@ class NET_EXPORT HttpResponseHeaders
const base::Time& current_time) const;
// The following methods extract values from the response headers. If a
- // value is not present, then false is returned. Otherwise, true is returned
- // and the out param is assigned to the corresponding value.
+ // value is not present, or is invalid, then false is returned. Otherwise,
+ // true is returned and the out param is assigned to the corresponding value.
bool GetMaxAgeValue(base::TimeDelta* value) const;
bool GetAgeValue(base::TimeDelta* value) const;
bool GetDateValue(base::Time* value) const;
« no previous file with comments | « no previous file | net/http/http_response_headers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698