Enable url path fading all on Android configurations.
Previously, this was restricted to document mode, but that is
no longer desired and it should be enabled everywhere.
BUG=597147
Committed: https://crrev.com/328129ac349c860993a94ccb1a8944e2f500cc89
Cr-Commit-Position: refs/heads/master@{#383200}
4 years, 9 months ago
(2016-03-24 19:29:38 UTC)
#2
PTAL
gone
Guess we can't pull out this code into a superclass because not all Toolbar* classes ...
4 years, 9 months ago
(2016-03-24 19:33:29 UTC)
#3
Guess we can't pull out this code into a superclass because not all Toolbar*
classes have URL bars?
gone
(lgtm)
4 years, 9 months ago
(2016-03-24 19:33:48 UTC)
#4
(lgtm)
Ted C
moved to the base class and added null checks since you are correct that it ...
4 years, 9 months ago
(2016-03-24 20:24:56 UTC)
#5
moved to the base class and added null checks since you are correct that it
isn't guaranteed to be there.
But I was worried as well that these could drift over time, so moving it seemed
good.
Ted C
The CQ bit was checked by tedchoc@chromium.org
4 years, 9 months ago
(2016-03-24 20:25:00 UTC)
#6
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827183002/20001
4 years, 9 months ago
(2016-03-24 20:25:25 UTC)
#8
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/40587) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, ...
4 years, 9 months ago
(2016-03-24 20:41:23 UTC)
#10
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827183002/40001
4 years, 9 months ago
(2016-03-24 20:44:04 UTC)
#13
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/43186)
4 years, 9 months ago
(2016-03-24 22:38:26 UTC)
#15
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827183002/60001
4 years, 9 months ago
(2016-03-24 23:47:13 UTC)
#18
4 years, 9 months ago
(2016-03-25 00:29:32 UTC)
#19
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
commit-bot: I haz the power
Description was changed from ========== Enable url path fading all on Android configurations. Previously, this ...
4 years, 9 months ago
(2016-03-25 00:30:45 UTC)
#20
Message was sent while issue was closed.
Description was changed from
==========
Enable url path fading all on Android configurations.
Previously, this was restricted to document mode, but that is
no longer desired and it should be enabled everywhere.
BUG=597147
==========
to
==========
Enable url path fading all on Android configurations.
Previously, this was restricted to document mode, but that is
no longer desired and it should be enabled everywhere.
BUG=597147
Committed: https://crrev.com/328129ac349c860993a94ccb1a8944e2f500cc89
Cr-Commit-Position: refs/heads/master@{#383200}
==========
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/328129ac349c860993a94ccb1a8944e2f500cc89 Cr-Commit-Position: refs/heads/master@{#383200}
4 years, 9 months ago
(2016-03-25 00:30:46 UTC)
#21
Issue 1827183002: Enable url path fading all on Android configurations.
(Closed)
Created 4 years, 9 months ago by Ted C
Modified 4 years, 9 months ago
Reviewers: gone
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0