Enable url path fading all on Android configurations.

Enable url path fading all on Android configurations.

Previously, this was restricted to document mode, but that is
no longer desired and it should be enabled everywhere.

BUG=597147
Committed: https://crrev.com/328129ac349c860993a94ccb1a8944e2f500cc89
Cr-Commit-Position: refs/heads/master@{#383200}

[Ted C, 2016-03-24 19:29:38]

tedchoc@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ted C, 2016-03-24 19:29:38]

PTAL

[gone, 2016-03-24 19:33:29]

Guess we can't pull out this code into a superclass because not all Toolbar*
classes have URL bars?

[gone, 2016-03-24 19:33:48]

(lgtm)

[Ted C, 2016-03-24 20:24:56]

moved to the base class and added null checks since you are correct that it
isn't guaranteed to be there.

But I was worried as well that these could drift over time, so moving it seemed
good.

[Ted C, 2016-03-24 20:25:00]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-03-24 20:25:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1827183002/#ps20001
(title: "Move to the base class")

[commit-bot: I haz the power, 2016-03-24 20:25:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827183002/20001

[commit-bot: I haz the power, 2016-03-24 20:41:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 20:41:23]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Ted C, 2016-03-24 20:43:28]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-03-24 20:43:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1827183002/#ps40001
(title: "Use correct Nullable")

[commit-bot: I haz the power, 2016-03-24 20:44:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827183002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827183002/40001

[commit-bot: I haz the power, 2016-03-24 22:38:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 22:38:26]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ted C, 2016-03-24 23:46:44]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-03-24 23:46:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1827183002/#ps60001
(title: "Fix test by using the full text from the UrlContainer")

[commit-bot: I haz the power, 2016-03-24 23:47:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827183002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827183002/60001

[commit-bot: I haz the power, 2016-03-25 00:29:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-25 00:30:45]

Description was changed from

==========
Enable url path fading all on Android configurations.

Previously, this was restricted to document mode, but that is
no longer desired and it should be enabled everywhere.

BUG=597147
==========

to

==========
Enable url path fading all on Android configurations.

Previously, this was restricted to document mode, but that is
no longer desired and it should be enabled everywhere.

BUG=597147

Committed: https://crrev.com/328129ac349c860993a94ccb1a8944e2f500cc89
Cr-Commit-Position: refs/heads/master@{#383200}
==========

[commit-bot: I haz the power, 2016-03-25 00:30:46]

Patchset 4 (id:??) landed as
https://crrev.com/328129ac349c860993a94ccb1a8944e2f500cc89
Cr-Commit-Position: refs/heads/master@{#383200}