content/test/test_render_frame_host.cc - Issue 182713005: Remove frame ID from DidCommitProvisionalLoad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_render_frame_host.cc

Issue 182713005: Remove frame ID from DidCommitProvisionalLoad. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix John's comments and signin test Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/test_render_frame_host.cc

diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc

index 0c3c5790aa9c96f0e6f97ced34cabcbcf00c5b1e..3e77c7fafacd4d6f21e19b715f9f26c18224eb7a 100644

--- a/content/test/test_render_frame_host.cc

+++ b/content/test/test_render_frame_host.cc

@@ -80,7 +80,6 @@ void TestRenderFrameHost::SendNavigateWithFile(

void TestRenderFrameHost::SendNavigateWithParams(

FrameHostMsg_DidCommitProvisionalLoad_Params* params) {

- params->frame_id = GetRoutingID();

FrameHostMsg_DidCommitProvisionalLoad msg(1, *params);

OnNavigate(msg);

}

@@ -94,7 +93,6 @@ void TestRenderFrameHost::SendNavigateWithParameters(

const base::FilePath* file_path_for_history_item) {

FrameHostMsg_DidCommitProvisionalLoad_Params params;

params.page_id = page_id;

- params.frame_id = GetRoutingID();

params.url = url;

params.referrer = Referrer();

params.transition = transition;