Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: content/public/browser/render_frame_host.h

Issue 182713005: Remove frame ID from DidCommitProvisionalLoad. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix John's comments and signin test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_
6 #define CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_ 6 #define CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_
7 7
8 #include "content/common/content_export.h" 8 #include "content/common/content_export.h"
9 #include "ipc/ipc_listener.h" 9 #include "ipc/ipc_listener.h"
10 #include "ipc/ipc_sender.h" 10 #include "ipc/ipc_sender.h"
11 #include "ui/gfx/native_widget_types.h" 11 #include "ui/gfx/native_widget_types.h"
12 #include "url/gurl.h" 12 #include "url/gurl.h"
13 13
14 namespace content { 14 namespace content {
15 class RenderProcessHost; 15 class RenderProcessHost;
16 class RenderViewHost; 16 class RenderViewHost;
17 class SiteInstance; 17 class SiteInstance;
18 struct CustomContextMenuContext; 18 struct CustomContextMenuContext;
19 19
20 // The interface provides a communication conduit with a frame in the renderer. 20 // The interface provides a communication conduit with a frame in the renderer.
21 class CONTENT_EXPORT RenderFrameHost : public IPC::Listener, 21 class CONTENT_EXPORT RenderFrameHost : public IPC::Listener,
22 public IPC::Sender { 22 public IPC::Sender {
23 public: 23 public:
24 // Returns the RenderFrameHost given its ID and the ID of its render process. 24 // Returns the RenderFrameHost given its ID and the ID of its render process.
25 // Returns NULL if the IDs do not correspond to a live RenderFrameHost. 25 // Returns NULL if the IDs do not correspond to a live RenderFrameHost.
26 static RenderFrameHost* FromID(int render_process_id, int render_frame_id); 26 static RenderFrameHost* FromID(int render_process_id, int render_frame_id);
27 27
28 virtual ~RenderFrameHost() {} 28 virtual ~RenderFrameHost() {}
29 29
30 // Returns the route id for this frame.
31 virtual int GetRoutingID() = 0;
jam 2014/03/03 16:08:04 nit: if you're changing this order, please also up
Charlie Reis 2014/03/03 17:05:23 I already did, right? Or did I put it in the wron
32
33 // Returns the SiteInstance grouping all RenderFrameHosts that have script
34 // access to this RenderFrameHost, and must therefore live in the same
35 // process.
30 virtual SiteInstance* GetSiteInstance() = 0; 36 virtual SiteInstance* GetSiteInstance() = 0;
31 37
32 // Returns the process for this frame. 38 // Returns the process for this frame.
33 virtual RenderProcessHost* GetProcess() = 0; 39 virtual RenderProcessHost* GetProcess() = 0;
34 40
35 // Returns the route id for this frame.
36 virtual int GetRoutingID() = 0;
37
38 // Returns the current RenderFrameHost of the parent frame, or NULL if there 41 // Returns the current RenderFrameHost of the parent frame, or NULL if there
39 // is no parent. The result may be in a different process than the current 42 // is no parent. The result may be in a different process than the current
40 // RenderFrameHost. 43 // RenderFrameHost.
41 virtual RenderFrameHost* GetParent() = 0; 44 virtual RenderFrameHost* GetParent() = 0;
42 45
43 // Returns true if the frame is out of process. 46 // Returns true if the frame is out of process.
44 virtual bool IsCrossProcessSubframe() = 0; 47 virtual bool IsCrossProcessSubframe() = 0;
45 48
46 // Returns the last committed URL of the frame. 49 // Returns the last committed URL of the frame.
47 virtual GURL GetLastCommittedURL() = 0; 50 virtual GURL GetLastCommittedURL() = 0;
(...skipping 14 matching lines...) Expand all
62 65
63 private: 66 private:
64 // This interface should only be implemented inside content. 67 // This interface should only be implemented inside content.
65 friend class RenderFrameHostImpl; 68 friend class RenderFrameHostImpl;
66 RenderFrameHost() {} 69 RenderFrameHost() {}
67 }; 70 };
68 71
69 } // namespace content 72 } // namespace content
70 73
71 #endif // CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_ 74 #endif // CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698