Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: content/browser/frame_host/navigator_delegate.h

Issue 182713005: Remove frame ID from DidCommitProvisionalLoad. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix John's comments and signin test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_delegate.h
diff --git a/content/browser/frame_host/navigator_delegate.h b/content/browser/frame_host/navigator_delegate.h
index 1903ffa4397d376f53a3dba1dd3abf3b909d05e6..75280de2e4d0dfa80b1e40681a7a43f7ce0b4838 100644
--- a/content/browser/frame_host/navigator_delegate.h
+++ b/content/browser/frame_host/navigator_delegate.h
@@ -52,14 +52,12 @@ class CONTENT_EXPORT NavigatorDelegate {
const GURL& validated_target_url) {}
// A navigation was committed in |render_frame_host|.
- // TODO(creis): Remove |frame_id| in favor of the RFH's routing ID.
virtual void DidCommitProvisionalLoad(
- int64 frame_id,
+ RenderFrameHostImpl* render_frame_host,
const base::string16& frame_unique_name,
bool is_main_frame,
const GURL& url,
- PageTransition transition_type,
- RenderFrameHostImpl* render_frame_host) {}
+ PageTransition transition_type) {}
// Handles post-navigation tasks in navigation AFTER the entry has been
// committed to the NavigationController. Note that the NavigationEntry is

Powered by Google App Engine
This is Rietveld 408576698