Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: content/browser/frame_host/navigator_delegate.h

Issue 182713005: Remove frame ID from DidCommitProvisionalLoad. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix John's comments and signin test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "content/public/browser/invalidate_type.h" 9 #include "content/public/browser/invalidate_type.h"
10 #include "content/public/browser/navigation_controller.h" 10 #include "content/public/browser/navigation_controller.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 bool is_main_frame, 45 bool is_main_frame,
46 int error_code, 46 int error_code,
47 const base::string16& error_description) {} 47 const base::string16& error_description) {}
48 48
49 // A redirect was processed in |render_frame_host| during a provisional load. 49 // A redirect was processed in |render_frame_host| during a provisional load.
50 virtual void DidRedirectProvisionalLoad( 50 virtual void DidRedirectProvisionalLoad(
51 RenderFrameHostImpl* render_frame_host, 51 RenderFrameHostImpl* render_frame_host,
52 const GURL& validated_target_url) {} 52 const GURL& validated_target_url) {}
53 53
54 // A navigation was committed in |render_frame_host|. 54 // A navigation was committed in |render_frame_host|.
55 // TODO(creis): Remove |frame_id| in favor of the RFH's routing ID.
56 virtual void DidCommitProvisionalLoad( 55 virtual void DidCommitProvisionalLoad(
57 int64 frame_id, 56 RenderFrameHostImpl* render_frame_host,
58 const base::string16& frame_unique_name, 57 const base::string16& frame_unique_name,
59 bool is_main_frame, 58 bool is_main_frame,
60 const GURL& url, 59 const GURL& url,
61 PageTransition transition_type, 60 PageTransition transition_type) {}
62 RenderFrameHostImpl* render_frame_host) {}
63 61
64 // Handles post-navigation tasks in navigation AFTER the entry has been 62 // Handles post-navigation tasks in navigation AFTER the entry has been
65 // committed to the NavigationController. Note that the NavigationEntry is 63 // committed to the NavigationController. Note that the NavigationEntry is
66 // not provided since it may be invalid/changed after being committed. The 64 // not provided since it may be invalid/changed after being committed. The
67 // NavigationController's last committed entry is for this navigation. 65 // NavigationController's last committed entry is for this navigation.
68 virtual void DidNavigateMainFramePostCommit( 66 virtual void DidNavigateMainFramePostCommit(
69 const LoadCommittedDetails& details, 67 const LoadCommittedDetails& details,
70 const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {} 68 const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {}
71 virtual void DidNavigateAnyFramePostCommit( 69 virtual void DidNavigateAnyFramePostCommit(
72 RenderFrameHostImpl* render_frame_host, 70 RenderFrameHostImpl* render_frame_host,
(...skipping 16 matching lines...) Expand all
89 // NavigationEntry has started in the browser process. 87 // NavigationEntry has started in the browser process.
90 virtual void DidStartNavigationToPendingEntry( 88 virtual void DidStartNavigationToPendingEntry(
91 RenderFrameHostImpl* render_frame_host, 89 RenderFrameHostImpl* render_frame_host,
92 const GURL& url, 90 const GURL& url,
93 NavigationController::ReloadType reload_type) {} 91 NavigationController::ReloadType reload_type) {}
94 }; 92 };
95 93
96 } // namspace content 94 } // namspace content
97 95
98 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_ 96 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698