Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 18271010: Make root invocation less crazy so that multiprocessing works on Windows (Closed)

Created:
7 years, 5 months ago by scottmg
Modified:
7 years, 5 months ago
Reviewers:
Nico, Isaac (away)
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Make root invocation less crazy so that multiprocessing works on Windows Previously gyp.bat runs "python gyp" and "gyp" imports "gyp" expecting to get pylib/gyp/__init__.py. Multiprocessing tries to fork and doesn't find the entry point named gyp because it doesn't search for non-.py extensions. Instead, make non-Windows match with a wrapper 'gyp' in bash, and make the python entry point gyp_main.py so that importing works more normally. Also, remove "Using parallel processing..." message so that tests pass, otherwise they complain that there was output on stderr. This was failing on other OSs too. R=thakis@chromium.org BUG=154205 Committed: https://code.google.com/p/gyp/source/detail?r=1667

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M gyp View 1 1 chunk +7 lines, -18 lines 1 comment Download
M gyp.bat View 1 chunk +1 line, -1 line 0 comments Download
A + gyp_main.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M pylib/gyp/input.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
lgtm, lebtm if the CL description contains bits from what you wrote on the bug ...
7 years, 5 months ago (2013-07-08 22:12:51 UTC) #1
scottmg
On 2013/07/08 22:12:51, Nico wrote: > lgtm, lebtm if the CL description contains bits from ...
7 years, 5 months ago (2013-07-08 22:27:38 UTC) #2
scottmg
Committed patchset #2 manually as r1667.
7 years, 5 months ago (2013-07-08 22:36:11 UTC) #3
Isaac (away)
https://chromiumcodereview.appspot.com/18271010/diff/1005/gyp File gyp (right): https://chromiumcodereview.appspot.com/18271010/diff/1005/gyp#newcode7 gyp:7: python $BASE/gyp_main.py nit: could use exec here to avoid ...
7 years, 5 months ago (2013-07-10 08:23:37 UTC) #4
Dirk Pranke
7 years, 5 months ago (2013-07-19 01:32:36 UTC) #5
Message was sent while issue was closed.
On 2013/07/10 08:23:37, Isaac wrote:
> https://chromiumcodereview.appspot.com/18271010/diff/1005/gyp
> File gyp (right):
> 
> https://chromiumcodereview.appspot.com/18271010/diff/1005/gyp#newcode7
> gyp:7: python $BASE/gyp_main.py
> nit: could use exec here to avoid the extra process.

Woot to getting this working on windows. The win python multiprocessing dance
you jumped through is a hassle (we do it in webkitpy in several places) :(.

Powered by Google App Engine
This is Rietveld 408576698