Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1827083005: [Extensions] Convert APIs to use movable types [9] (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tzik, kinuko+fileapi, nhiroki, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert APIs to use movable types [9] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - processes.idl - proxy.json - resources_private.idl - screenlock_private.idl - sessions.json - settings_private.idl - signed_in_devices.idl - streams_private.idl - sync_file_system.idl - system_indicator.idl - system_private.json - tab_capture.idl - tabs.json BUG=595949 Committed: https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631 Cr-Commit-Position: refs/heads/master@{#383625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -103 lines) Patch
M chrome/browser/extensions/api/processes/processes_api.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 7 chunks +20 lines, -26 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/settings_private_event_router.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M chrome/common/extensions/api/processes.idl View 4 chunks +49 lines, -49 lines 0 comments Download
M chrome/common/extensions/api/proxy.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/resources_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/screenlock_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/sessions.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/settings_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/signed_in_devices.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/streams_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/sync_file_system.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/system_indicator.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/system_private.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/tab_capture.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/tabs.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Devlin
4 years, 9 months ago (2016-03-25 14:22:47 UTC) #3
asargent_no_longer_on_chrome
lgtm
4 years, 9 months ago (2016-03-25 20:22:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827083005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827083005/1
4 years, 8 months ago (2016-03-29 00:09:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 00:15:11 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 00:17:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631
Cr-Commit-Position: refs/heads/master@{#383625}

Powered by Google App Engine
This is Rietveld 408576698