Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

Issue 1827083005: [Extensions] Convert APIs to use movable types [9] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
index 61292b7849cef080b662a52d918486049ecf87a9..786d1ec98fe2d1fcb6ae4a552adfba7c538f1c4c 100644
--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
@@ -65,15 +65,11 @@ void SignedInDevicesChangeObserver::OnDeviceInfoChange() {
ScopedVector<DeviceInfo> devices = GetAllSignedInDevices(extension_id_,
profile_);
- std::vector<linked_ptr<api::signed_in_devices::DeviceInfo> > args;
-
- for (ScopedVector<DeviceInfo>::const_iterator it = devices.begin();
- it != devices.end();
- ++it) {
- linked_ptr<api::signed_in_devices::DeviceInfo> api_device =
- make_linked_ptr(new api::signed_in_devices::DeviceInfo);
- FillDeviceInfo(*(*it), api_device.get());
- args.push_back(api_device);
+ std::vector<api::signed_in_devices::DeviceInfo> args;
+ for (const DeviceInfo* info : devices) {
+ api::signed_in_devices::DeviceInfo api_device;
+ FillDeviceInfo(*info, &api_device);
+ args.push_back(std::move(api_device));
}
scoped_ptr<base::ListValue> result =

Powered by Google App Engine
This is Rietveld 408576698