Remove shaped desktop support from remoting host and client.

Remove shaped desktop support from remoting host and client.

We no longer need to support shaped desktop, so the corresponding
code can be removed.

Committed: https://crrev.com/24ed25b8af345a6004dfc45f52401aebe20ac76e
Cr-Commit-Position: refs/heads/master@{#383340}

[Sergey Ulanov, 2016-03-24 21:56:21]

sergeyu@chromium.org changed reviewers:
+ joedow@chromium.org

[joedow, 2016-03-25 01:26:19]

lgtm

https://codereview.chromium.org/1827043004/diff/1/remoting/proto/video.proto
File remoting/proto/video.proto (left):

https://codereview.chromium.org/1827043004/diff/1/remoting/proto/video.proto#...
remoting/proto/video.proto:62: repeated Rect desktop_shape_rects = 10;
Is it useful to leave a comment that fields 10 and 11 were retired so they
aren't accidentally reused in the future?

https://codereview.chromium.org/1827043004/diff/1/remoting/webapp/base/js/cli...
File remoting/webapp/base/js/client_plugin_impl.js (left):

https://codereview.chromium.org/1827043004/diff/1/remoting/webapp/base/js/cli...
remoting/webapp/base/js/client_plugin_impl.js:268:
this.hostDesktop_.onShapeUpdated(message);
I think you can also remove the onShapeUpdated method:
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/webapp/ba...

[Jamie, 2016-03-25 17:17:17]

jamiewalch@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-03-25 17:17:18]

https://codereview.chromium.org/1827043004/diff/1/remoting/proto/video.proto
File remoting/proto/video.proto (left):

https://codereview.chromium.org/1827043004/diff/1/remoting/proto/video.proto#...
remoting/proto/video.proto:62: repeated Rect desktop_shape_rects = 10;
On 2016/03/25 01:26:18, joedow wrote:
> Is it useful to leave a comment that fields 10 and 11 were retired so they
> aren't accidentally reused in the future?

Or even rename them DEPRECATED_* so that they can't be reused?

[Sergey Ulanov, 2016-03-25 19:32:05]

Patchset #2 (id:20001) has been deleted

[Sergey Ulanov, 2016-03-25 19:33:15]

https://codereview.chromium.org/1827043004/diff/1/remoting/proto/video.proto
File remoting/proto/video.proto (left):

https://codereview.chromium.org/1827043004/diff/1/remoting/proto/video.proto#...
remoting/proto/video.proto:62: repeated Rect desktop_shape_rects = 10;
On 2016/03/25 01:26:18, joedow wrote:
> Is it useful to leave a comment that fields 10 and 11 were retired so they
> aren't accidentally reused in the future?

Done.

https://codereview.chromium.org/1827043004/diff/1/remoting/proto/video.proto#...
remoting/proto/video.proto:62: repeated Rect desktop_shape_rects = 10;
On 2016/03/25 17:17:18, Jamie wrote:
> On 2016/03/25 01:26:18, joedow wrote:
> > Is it useful to leave a comment that fields 10 and 11 were retired so they
> > aren't accidentally reused in the future?
> 
> Or even rename them DEPRECATED_* so that they can't be reused?

If we keep them as deprecated protobuf will still generate the code for these
fields. In the past we were removing fields and I think it's very unlikely to
cause any problems. It's usually obvious which fields have been used when there
are gaps in the field IDs. Normally these fields IDs would be marked as
reserved, see
https://developers.google.com/protocol-buffers/docs/reference/proto2-spec#res...
. But this feature is not supported in the version of protobuf we use.

https://codereview.chromium.org/1827043004/diff/1/remoting/webapp/base/js/cli...
File remoting/webapp/base/js/client_plugin_impl.js (left):

https://codereview.chromium.org/1827043004/diff/1/remoting/webapp/base/js/cli...
remoting/webapp/base/js/client_plugin_impl.js:268:
this.hostDesktop_.onShapeUpdated(message);
On 2016/03/25 01:26:19, joedow wrote:
> I think you can also remove the onShapeUpdated method:
>
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/webapp/ba...

Done.

[Sergey Ulanov, 2016-03-25 19:33:31]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-03-25 19:33:31]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/1827043004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-25 19:33:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827043004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827043004/40001

[commit-bot: I haz the power, 2016-03-25 20:27:30]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-25 20:29:07]

Description was changed from

==========
Remove shaped desktop support from remoting host and client.

We no longer need to support shaped desktop, so the corresponding
code can be removed.
==========

to

==========
Remove shaped desktop support from remoting host and client.

We no longer need to support shaped desktop, so the corresponding
code can be removed.

Committed: https://crrev.com/24ed25b8af345a6004dfc45f52401aebe20ac76e
Cr-Commit-Position: refs/heads/master@{#383340}
==========

[commit-bot: I haz the power, 2016-03-25 20:29:08]

Patchset 2 (id:??) landed as
https://crrev.com/24ed25b8af345a6004dfc45f52401aebe20ac76e
Cr-Commit-Position: refs/heads/master@{#383340}