Remove shaped desktop support from remoting host and client.

remoting/proto/video.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Protocol for video messages.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
@@ skipping 40 matching lines @@
   // Time in milliseconds spent in capturing this video frame.
   optional int64 capture_time_ms = 7;
 
   // Time in milliseconds spent in encoding this video frame.
   optional int64 encode_time_ms = 8;
 
   // The client's timestamp of the latest event received by the host before
   // starting to capture this video frame.
   optional int64 latest_event_timestamp = 9;
 
-  // Provides the new shape for this frame, iff |use_desktop_shape| is true.
-  repeated Rect desktop_shape_rects = 10;

[joedow, 2016/03/25 01:26:18]

Is it useful to leave a comment that fields 10 and 11 were retired so they
aren't accidentally reused in the future?

[Jamie, 2016/03/25 17:17:18]

Or even rename them DEPRECATED_* so that they can't be reused?

[Sergey Ulanov, 2016/03/25 19:33:14]

Done.

[Sergey Ulanov, 2016/03/25 19:33:14]

If we keep them as deprecated protobuf will still generate the code for these
fields. In the past we were removing fields and I think it's very unlikely to
cause any problems. It's usually obvious which fields have been used when there
are gaps in the field IDs. Normally these fields IDs would be marked as
reserved, see
https://developers.google.com/protocol-buffers/docs/reference/proto2-spec#res...
. But this feature is not supported in the version of protobuf we use.

-
-  // True when |desktop_shape_rects| should be used, false to indicate that
-  // the frame is un-shaped. If the shape has not changed since the preceding
-  // frame then this field should be omitted.
-  optional bool use_desktop_shape = 11;
-
   // Optional frame timestamp. Used in tests to estimate frame latency.
   optional int64 timestamp = 12;
 
   // Frame identifier used to match VideoFrame and VideoAck.
   optional int32 frame_id = 13;
 
   // Time from when the last event was received until capturing has started.
   optional int64 capture_pending_time_ms = 14;
 
   // Total overhead time for IPC and threading when capturing frames.
   optional int64 capture_overhead_time_ms = 15;
 
   // Time between when the frame was captured and when encoder started encoding
   // it.
   optional int64 encode_pending_time_ms = 16;
 
   // Time for which the frame is blocked until it's sent to the client.
   optional int64 send_pending_time_ms = 17;
 }
 
 // VideoAck acknowledges that the frame in the VideoPacket with the same
 // frame_id has been rendered. VideoAck messages must be sent only for frames
 // that have frame_id field set. They must be sent the same order in which
 // the corresponding VideoPackets were received.
 message VideoAck {
   // Frame ID.
   optional int32 frame_id = 1;
 }