chrome/test/chromedriver/chrome/chrome_remote_impl.h - Issue 1827003004: [Chromedriver] Chromedriver should handle unexpected alert automatically.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_remote_impl.h

Issue 1827003004: [Chromedriver] Chromedriver should handle unexpected alert automatically. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: New modifications Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/capabilities.cc ('K') | « chrome/test/chromedriver/chrome/chrome_impl.cc ('k') | chrome/test/chromedriver/chrome/chrome_remote_impl.cc » ('j') | chrome/test/chromedriver/test/run_py_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/chrome_remote_impl.h

diff --git a/chrome/test/chromedriver/chrome/chrome_remote_impl.h b/chrome/test/chromedriver/chrome/chrome_remote_impl.h

index 656b2aed5c61778339e3c4b4ac5ebcfa4fb28e51..c3301cc454e5f00d255c18daf74770c461e9511b 100644

--- a/chrome/test/chromedriver/chrome/chrome_remote_impl.h

+++ b/chrome/test/chromedriver/chrome/chrome_remote_impl.h

@@ -20,6 +20,7 @@ class ChromeRemoteImpl : public ChromeImpl {

std::unique_ptr<DevToolsHttpClient> http_client,

std::unique_ptr<DevToolsClient> websocket_client,

ScopedVector<DevToolsEventListener>& devtools_event_listeners,

+ std::string unexpected_alert_behaviour,

std::string page_load_strategy);

~ChromeRemoteImpl() override;