Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/test/chromedriver/chrome/chrome_remote_impl.cc

Issue 1827003004: [Chromedriver] Chromedriver should handle unexpected alert automatically. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: New modifications Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_remote_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_remote_impl.cc b/chrome/test/chromedriver/chrome/chrome_remote_impl.cc
index 5b9a669d29a1cb0e71f6b6697426fb33fd561609..e3e7751253d67fc5b4aed64cd9ea1c9bf3fef295 100644
--- a/chrome/test/chromedriver/chrome/chrome_remote_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_remote_impl.cc
@@ -15,11 +15,13 @@ ChromeRemoteImpl::ChromeRemoteImpl(
std::unique_ptr<DevToolsHttpClient> http_client,
std::unique_ptr<DevToolsClient> websocket_client,
ScopedVector<DevToolsEventListener>& devtools_event_listeners,
+ std::string unexpected_alert_behaviour,
std::string page_load_strategy)
: ChromeImpl(std::move(http_client),
std::move(websocket_client),
devtools_event_listeners,
std::unique_ptr<PortReservation>(),
+ unexpected_alert_behaviour,
page_load_strategy) {}
ChromeRemoteImpl::~ChromeRemoteImpl() {}

Powered by Google App Engine
This is Rietveld 408576698