[Chromedriver] Chromedriver should handle unexpected alert automatically.

chrome/test/chromedriver/window_commands.cc

Index: chrome/test/chromedriver/window_commands.cc
diff --git a/chrome/test/chromedriver/window_commands.cc b/chrome/test/chromedriver/window_commands.cc
index 4f357c244d5ff0befe831df90051e772a9119a28..6540ee41dd3ee56351d88f6e980758c166e7ba15 100644
--- a/chrome/test/chromedriver/window_commands.cc
+++ b/chrome/test/chromedriver/window_commands.cc
@@ -222,6 +222,10 @@ Status ExecuteWindowCommand(
         web_view->GetJavaScriptDialogManager()->GetDialogMessage(&alert_text);
     if (status.IsError())
       return status;
+    status = web_view->GetJavaScriptDialogManager()

[samuong, 2016/03/30 17:22:56]

please add a comment above this line saying:

// Close the dialog before returning an error, so that subsequent commands do
not fail.

[gmanikpure, 2016/04/01 16:54:07]

Done.

+        ->HandleDialog(true, session->prompt_text.get());

[samuong, 2016/03/30 17:22:56]

nit: break line after the opening ( for HandleDialog rather than before the ->

[gmanikpure, 2016/04/01 16:54:07]

Done.

+    if (status.IsError())
+      return status;
     return Status(kUnexpectedAlertOpen, "{Alert text : " + alert_text + "}");
   }