[Chromedriver] Chromedriver should handle unexpected alert automatically.

chrome/test/chromedriver/window_commands.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/window_commands.h"
 
 #include <stddef.h>
 
 #include <list>
 #include <string>
@@ skipping 204 matching lines @@
   status = web_view->HandleReceivedEvents();
   if (status.IsError())
     return status;
 
   if (web_view->GetJavaScriptDialogManager()->IsDialogOpen()) {
     std::string alert_text;
     status =
         web_view->GetJavaScriptDialogManager()->GetDialogMessage(&alert_text);
     if (status.IsError())
       return status;
+    status = web_view->GetJavaScriptDialogManager()

[samuong, 2016/03/30 17:22:56]

please add a comment above this line saying:

// Close the dialog before returning an error, so that subsequent commands do
not fail.

[gmanikpure, 2016/04/01 16:54:07]

Done.

+        ->HandleDialog(true, session->prompt_text.get());

[samuong, 2016/03/30 17:22:56]

nit: break line after the opening ( for HandleDialog rather than before the ->

[gmanikpure, 2016/04/01 16:54:07]

Done.

+    if (status.IsError())
+      return status;
     return Status(kUnexpectedAlertOpen, "{Alert text : " + alert_text + "}");
   }
 
   Status nav_status(kOk);
   for (int attempt = 0; attempt < 3; attempt++) {
     if (attempt == 2) {
       // Switch to main frame and retry command if subframe no longer exists.
       session->SwitchToTopFrame();
     }
 
@@ skipping 818 matching lines @@
   return status;
 }
 
 Status ExecuteTakeHeapSnapshot(
     Session* session,
     WebView* web_view,
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value) {
   return web_view->TakeHeapSnapshot(value);
 }