Correctly report stack trace when current function is FunctionApply builtin

Correctly report stack trace when current function is FunctionApply builtin

When pc is inside FunctionApply builtin function the top frame may be either 
2) Internal stack frame created by FunctionApply itself.
In this case we know its caller's pc and can correctly resolve calling function.
1) Frame of the calling JavaScript function that invoked .apply(). In this case we have no practical reliable way to find out the caller's pc so we mark the caller's frame as 'unresolved'.

All this logic is implemented in ProfileGenerator. SafeStackFrameIterator is extended to provide type of the current top stack frame (iteration actually starts from the caller's frame as we know top function from pc).

BUG=252097
R=jkummerow@chromium.org, loislo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15468

[loislo, 2013-07-03 08:50:32]

lgtm

https://codereview.chromium.org/18269003/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

https://codereview.chromium.org/18269003/diff/1/src/profile-generator.h#newco...
src/profile-generator.h:119: Logger::LogEventsAndTags tag() const { return tag_;
}
revert?

[yurys, 2013-07-03 08:56:06]

https://codereview.chromium.org/18269003/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

https://codereview.chromium.org/18269003/diff/1/src/profile-generator.h#newco...
src/profile-generator.h:119: Logger::LogEventsAndTags tag() const { return tag_;
}
On 2013/07/03 08:50:32, loislo wrote:
> revert?

Done.

[Jakob Kummerow, 2013-07-03 11:41:50]

lgtm

https://codereview.chromium.org/18269003/diff/6001/test/cctest/test-cpu-profi...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/18269003/diff/6001/test/cctest/test-cpu-profi...
test/cctest/test-cpu-profiler.cc:1198: 
nit: if Rietveld isn't lying and this is an empty line at the end of the file,
please delete it. (Files should end with a single \n, not two in a row.)

[yurys, 2013-07-03 13:52:08]

https://codereview.chromium.org/18269003/diff/6001/test/cctest/test-cpu-profi...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/18269003/diff/6001/test/cctest/test-cpu-profi...
test/cctest/test-cpu-profiler.cc:1198: 
On 2013/07/03 11:41:50, Jakob wrote:
> nit: if Rietveld isn't lying and this is an empty line at the end of the file,
> please delete it. (Files should end with a single \n, not two in a row.)

Done.

[yurys, 2013-07-03 14:04:46]

Committed patchset #5 manually as r15468 (presubmit successful).