src/sampler.cc - Issue 18269003: Correctly report stack trace when current function is FunctionApply builtin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/sampler.cc

Issue 18269003: Correctly report stack trace when current function is FunctionApply builtin (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix test Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/sampler.cc

diff --git a/src/sampler.cc b/src/sampler.cc

index 6d97110b1d5deecd08e518deb20d3d1870d4ae36..63d0aa88cc722468602f1da7ac023071a268c76c 100644

--- a/src/sampler.cc

+++ b/src/sampler.cc

@@ -637,6 +637,7 @@ DISABLE_ASAN void TickSample::Trace(Isolate* isolate) {

}

SafeStackFrameIterator it(isolate, fp, sp, sp, js_entry_sp);

+ top_frame_type = it.top_frame_type();

int i = 0;

while (!it.done() && i < TickSample::kMaxFramesCount) {

stack[i++] = it.frame()->pc();

« no previous file with comments | « src/sampler.h ('k') | test/cctest/test-cpu-profiler.cc » ('j') | no next file with comments »