Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1826743002: Function profile should respect --show-invisible-frames (Closed)

Created:
4 years, 9 months ago by Cutch
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Function profile should respect --show-invisible-frames This also improves the function profile by filtering out invisible frames. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/afeae0eb697f0ad626ea08ccf31ab0d0aa18fd24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M runtime/vm/profiler_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/profiler_service.cc View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
4 years, 9 months ago (2016-03-23 14:09:07 UTC) #4
rmacnak
lgtm
4 years, 9 months ago (2016-03-23 21:51:08 UTC) #5
Cutch
4 years, 9 months ago (2016-03-23 22:01:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
afeae0eb697f0ad626ea08ccf31ab0d0aa18fd24 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698