Function profile should respect --show-invisible-frames

runtime/vm/profiler_service.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/profiler_service.h"
 
 #include "vm/growable_array.h"
 #include "vm/log.h"
 #include "vm/native_symbol.h"
 #include "vm/object.h"
 #include "vm/os.h"
 #include "vm/profiler.h"
 #include "vm/reusable_handles.h"
 #include "vm/scope_timer.h"
 
 namespace dart {
 
 DECLARE_FLAG(int, max_profile_depth);
 DECLARE_FLAG(int, profile_period);
+DECLARE_FLAG(bool, show_invisible_frames);
 
 DEFINE_FLAG(bool, trace_profiler, false, "Trace profiler.");
 
 #ifndef PRODUCT
 
 class DeoptimizedCodeSet : public ZoneAllocated {
  public:
   explicit DeoptimizedCodeSet(Isolate* isolate)
       : previous_(
             GrowableObjectArray::ZoneHandle(isolate->deoptimized_code_array())),
@@ skipping 100 matching lines @@
   if (name_ != NULL) {
     return name_;
   }
   ASSERT(!function_.IsNull());
   const String& func_name =
       String::Handle(function_.QualifiedUserVisibleName());
   return func_name.ToCString();
 }
 
 
+bool ProfileFunction::is_visible() const {
+  if (function_.IsNull()) {
+    // Some synthetic function.
+    return true;
+  }
+  return FLAG_show_invisible_frames || function_.is_visible();
+}
+
+
 void ProfileFunction::Tick(bool exclusive,
                            intptr_t inclusive_serial,
                            TokenPosition token_position) {
   if (exclusive) {
     exclusive_ticks_++;
     TickSourcePosition(token_position, exclusive);
   }
   // Fall through and tick inclusive count too.
   if (inclusive_serial_ == inclusive_serial) {
     // Already ticked.
@@ skipping 1458 matching lines @@
     return IsExecutingFrame(sample, frame_index) || vm_tags_emitted();
   }
 
   ProfileFunctionTrieNode* ProcessFunction(ProfileFunctionTrieNode* current,
                                            intptr_t sample_index,
                                            ProcessedSample* sample,
                                            intptr_t frame_index,
                                            ProfileFunction* function,
                                            TokenPosition token_position,
                                            intptr_t code_index) {
+    if (!function->is_visible()) {
+      return current;
+    }
     if (tick_functions_) {
       if (FLAG_trace_profiler) {
         THR_Print("S[%" Pd "]F[%" Pd "] %s %s 0x%" Px "\n",
                   sample_index,
                   frame_index,
                   function->Name(),
                   token_position.ToCString(),
                   sample->At(frame_index));
       }
       function->Tick(IsExecutingFrame(sample, frame_index),
@@ skipping 973 matching lines @@
   // Disable thread interrupts while processing the buffer.
   DisableThreadInterruptsScope dtis(thread);
 
   ClearProfileVisitor clear_profile(isolate);
   sample_buffer->VisitSamples(&clear_profile);
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart