Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1826703002: Fix a painting bug which occurred due to the change which reduces the size of the fullscreen chrome… (Closed)

Created:
4 years, 9 months ago by ananta
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Fix a painting bug which occurred due to the change which reduces the size of the fullscreen chrome window by 1 px on activation loss. Merging to M50 We reduce the size of fullscreen windows by 1px to ensure that maximized windows on the same thread don't draw over the taskbar. This change caused a painting problem as the compositor was not aware of the changed size. This causes the compositor to not paint correctly when the fullscreen window is activated as the window size did not change. Setting the compositor size correctly to the window bounds size fixes this problem. The other bug I found was when the fullscreen window is activated, we inform the delegate about the changed client size which in turn makes it across to the webcontents. We don't want the webcontents to get notified about these size changes. Fixed by setting the flag background_fullscreen_hack_ to false after the SetBoundsInternal call. BUG=595666 TBR=sky Review URL: https://codereview.chromium.org/1819633002 Cr-Commit-Position: refs/heads/master@{#382429} (cherry picked from commit 9f060d4be347cda7aa7c0fb2a43afafbbd64e70c) Conflicts: ui/views/win/hwnd_message_handler.cc Committed: https://chromium.googlesource.com/chromium/src/+/eb3477b1f3603bcc6eede00f1ce76370f3534c56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
ananta
4 years, 9 months ago (2016-03-23 00:09:35 UTC) #3
ananta
4 years, 9 months ago (2016-03-23 00:49:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb3477b1f3603bcc6eede00f1ce76370f3534c56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698