Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1819633002: Fix a painting bug which occurred due to the change which reduces the size of the fullscreen chrome… (Closed)

Created:
4 years, 9 months ago by ananta
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a painting bug which occurred due to the change which reduces the size of the fullscreen chrome window by 1 px on activation loss. We reduce the size of fullscreen windows by 1px to ensure that maximized windows on the same thread don't draw over the taskbar. This change caused a painting problem as the compositor was not aware of the changed size. This causes the compositor to not paint correctly when the fullscreen window is activated as the window size did not change. Setting the compositor size correctly to the window bounds size fixes this problem. The other bug I found was when the fullscreen window is activated, we inform the delegate about the changed client size which in turn makes it across to the webcontents. We don't want the webcontents to get notified about these size changes. Fixed by setting the flag background_fullscreen_hack_ to false after the SetBoundsInternal call. BUG=595666 Committed: https://crrev.com/9f060d4be347cda7aa7c0fb2a43afafbbd64e70c Cr-Commit-Position: refs/heads/master@{#382429}

Patch Set 1 #

Patch Set 2 : Rebased to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
ananta
4 years, 9 months ago (2016-03-19 01:55:11 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-21 17:04:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819633002/1
4 years, 9 months ago (2016-03-21 19:12:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/175448) ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-21 19:15:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819633002/20001
4 years, 9 months ago (2016-03-21 22:14:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 23:13:29 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 23:14:59 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f060d4be347cda7aa7c0fb2a43afafbbd64e70c
Cr-Commit-Position: refs/heads/master@{#382429}

Powered by Google App Engine
This is Rietveld 408576698