Fix a painting bug which occurred due to the change which reduces the size of the fullscreen chrome…

Fix a painting bug which occurred due to the change which reduces the size of the fullscreen chrome window by 1 px on activation loss.

We reduce the size of fullscreen windows by 1px to ensure that maximized windows on the same thread don't draw over the
taskbar. This change caused a painting problem as the compositor was not aware of the changed size. This causes the compositor
to not paint correctly when the fullscreen window is activated as the window size did not change.

Setting the compositor size correctly to the window bounds size fixes this problem. The other bug I found was when the
fullscreen window is activated, we inform the delegate about the changed client size which in turn makes it across to the
webcontents. We don't want the webcontents to get notified about these size changes. Fixed by setting the flag background_fullscreen_hack_
to false after the SetBoundsInternal call.

BUG=595666
Committed: https://crrev.com/9f060d4be347cda7aa7c0fb2a43afafbbd64e70c
Cr-Commit-Position: refs/heads/master@{#382429}

[ananta, 2016-03-19 01:55:11]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-03-21 17:04:12]

LGTM

[ananta, 2016-03-21 19:11:39]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2016-03-21 19:12:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819633002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819633002/1

[commit-bot: I haz the power, 2016-03-21 19:15:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 19:15:16]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ananta, 2016-03-21 22:14:14]

The CQ bit was checked by ananta@chromium.org

[ananta, 2016-03-21 22:14:15]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1819633002/#ps20001
(title: "Rebased to tip")

[commit-bot: I haz the power, 2016-03-21 22:14:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819633002/20001

[commit-bot: I haz the power, 2016-03-21 23:13:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-21 23:14:58]

Description was changed from

==========
Fix a painting bug which occurred due to the change which reduces the size of
the fullscreen chrome window by 1 px on activation loss.

We reduce the size of fullscreen windows by 1px to ensure that maximized windows
on the same thread don't draw over the
taskbar. This change caused a painting problem as the compositor was not aware
of the changed size. This causes the compositor
to not paint correctly when the fullscreen window is activated as the window
size did not change.

Setting the compositor size correctly to the window bounds size fixes this
problem. The other bug I found was when the
fullscreen window is activated, we inform the delegate about the changed client
size which in turn makes it across to the
webcontents. We don't want the webcontents to get notified about these size
changes. Fixed by setting the flag background_fullscreen_hack_
to false after the SetBoundsInternal call.

BUG=595666
==========

to

==========
Fix a painting bug which occurred due to the change which reduces the size of
the fullscreen chrome window by 1 px on activation loss.

We reduce the size of fullscreen windows by 1px to ensure that maximized windows
on the same thread don't draw over the
taskbar. This change caused a painting problem as the compositor was not aware
of the changed size. This causes the compositor
to not paint correctly when the fullscreen window is activated as the window
size did not change.

Setting the compositor size correctly to the window bounds size fixes this
problem. The other bug I found was when the
fullscreen window is activated, we inform the delegate about the changed client
size which in turn makes it across to the
webcontents. We don't want the webcontents to get notified about these size
changes. Fixed by setting the flag background_fullscreen_hack_
to false after the SetBoundsInternal call.

BUG=595666

Committed: https://crrev.com/9f060d4be347cda7aa7c0fb2a43afafbbd64e70c
Cr-Commit-Position: refs/heads/master@{#382429}
==========

[commit-bot: I haz the power, 2016-03-21 23:14:59]

Patchset 2 (id:??) landed as
https://crrev.com/9f060d4be347cda7aa7c0fb2a43afafbbd64e70c
Cr-Commit-Position: refs/heads/master@{#382429}