Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1826563002: 🌓 Stop lint.py pulling in implicit dependencies via AndroidManifest.xml (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
Reviewers:
samuong, jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, Lambros
Base URL:
https://chromium.googlesource.com/chromium/src.git@lint-cache-dir
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop lint.py pulling in implicit dependencies via AndroidManifest.xml This will mean even fewer UnusedResource checks, but that is covered by: https://bugs.chromium.org/p/chromium/issues/detail?id=595810 BUG=597007 Committed: https://crrev.com/26befa044b2ce9ed1b5dfd83eb5a67d1a964bb8c Cr-Commit-Position: refs/heads/master@{#382986}

Patch Set 1 #

Patch Set 2 : fix new lint error in chrome/test/chromedriver/test/webview_shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M build/android/gyp/lint.py View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/chromedriver/test/webview_shell/java/res/drawable/icon.png View 1 Binary file 0 comments Download
A + chrome/test/chromedriver/test/webview_shell/java/res/mipmap/icon.png View 1 Binary file 0 comments Download

Depends on Patchset:

Issue 1824093002 Patch 20001

Messages

Total messages: 23 (12 generated)
jbudorick
lgtm
4 years, 9 months ago (2016-03-22 20:43:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826563002/1
4 years, 9 months ago (2016-03-22 23:42:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/39343)
4 years, 9 months ago (2016-03-23 00:34:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826563002/20001
4 years, 9 months ago (2016-03-23 13:41:53 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/160041)
4 years, 9 months ago (2016-03-23 13:50:06 UTC) #12
agrieve
frankf@chromium.org: Please review changes in
4 years, 9 months ago (2016-03-23 14:07:33 UTC) #14
jbudorick
On 2016/03/23 14:07:33, agrieve wrote: > mailto:frankf@chromium.org: Please review changes in -frankf, +samuong
4 years, 9 months ago (2016-03-23 14:10:18 UTC) #16
samuong
lgtm
4 years, 9 months ago (2016-03-23 20:17:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826563002/20001
4 years, 9 months ago (2016-03-24 00:14:51 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-24 00:20:08 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 00:21:33 UTC) #23
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/26befa044b2ce9ed1b5dfd83eb5a67d1a964bb8c
Cr-Commit-Position: refs/heads/master@{#382986}

Powered by Google App Engine
This is Rietveld 408576698