🌓 Stop lint.py pulling in implicit dependencies via AndroidManifest.xml

build/android/gyp/lint.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Android's lint tool."""
 
 
 import argparse
@@ skipping 89 matching lines @@
     # There may be multiple source files with the same basename (but in
     # different directories). It is difficult to determine what part of the path
     # corresponds to the java package, and so instead just link the source files
     # into temporary directories (creating a new one whenever there is a name
     # conflict).
     src_dirs = []
     def NewSourceDir():
       new_dir = os.path.join(temp_dir, str(len(src_dirs)))
       os.mkdir(new_dir)
       src_dirs.append(new_dir)
-      cmd.extend(['--sources', _RelativizePath(new_dir)])
       return new_dir
 
     def PathInDir(d, src):
       return os.path.join(d, os.path.basename(src))
 
     for src in sources:
       src_dir = None
       for d in src_dirs:
         if not os.path.exists(PathInDir(d, src)):
           src_dir = d
           break
       if not src_dir:
         src_dir = NewSourceDir()
+        cmd.extend(['--sources', _RelativizePath(src_dir)])
       os.symlink(os.path.abspath(src), PathInDir(src_dir, src))
 
+    # Put the manifest in a temporary directory in order to avoid lint detecting
+    # sibling res/ and src/ directories (which should be pass explicitly if they
+    # are to be included).
     if manifest_path:
-      cmd.append(_RelativizePath(os.path.join(manifest_path, os.pardir)))
+      src_dir = NewSourceDir()
+      os.symlink(os.path.abspath(manifest_path),
+                 PathInDir(src_dir, manifest_path))
+      cmd.append(src_dir)
 
     if os.path.exists(result_path):
       os.remove(result_path)
 
     env = {}
     stderr_filter = None
     if cache_dir:
       # When _JAVA_OPTIONS is set, java prints to stderr:
       # Picked up _JAVA_OPTIONS: ...
       env['_JAVA_OPTIONS'] = '-Duser.home=%s' % _RelativizePath(cache_dir)
@@ skipping 146 matching lines @@
                                     silent=args.silent),
         args,
         input_paths=input_paths,
         input_strings=input_strings,
         output_paths=output_paths,
         pass_changes=True)
 
 
 if __name__ == '__main__':
   sys.exit(main())