Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1826463002: VM: Use propagated type to improve checked smi operations in aot compiler. (Closed)

Created:
4 years, 9 months ago by Florian Schneider
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Use propagated type to improve checked smi operations in aot compiler. Avoid checking inputs that are known to be smis. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ef1c7211bfab2303bc3aa2a825964ad60912d15e

Patch Set 1 #

Total comments: 2

Patch Set 2 : added missing case on arm64 #

Patch Set 3 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -13 lines) Patch
M runtime/vm/intermediate_language_arm.cc View 2 chunks +18 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 2 3 chunks +22 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +17 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +15 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
4 years, 9 months ago (2016-03-22 12:19:16 UTC) #2
rmacnak
lgtm w/c https://codereview.chromium.org/1826463002/diff/1/runtime/vm/intermediate_language_arm64.cc File runtime/vm/intermediate_language_arm64.cc (right): https://codereview.chromium.org/1826463002/diff/1/runtime/vm/intermediate_language_arm64.cc#newcode2815 runtime/vm/intermediate_language_arm64.cc:2815: if (left_cid == kSmiCid) { Missing same ...
4 years, 9 months ago (2016-03-22 16:46:16 UTC) #3
Florian Schneider
https://codereview.chromium.org/1826463002/diff/1/runtime/vm/intermediate_language_arm64.cc File runtime/vm/intermediate_language_arm64.cc (right): https://codereview.chromium.org/1826463002/diff/1/runtime/vm/intermediate_language_arm64.cc#newcode2815 runtime/vm/intermediate_language_arm64.cc:2815: if (left_cid == kSmiCid) { On 2016/03/22 16:46:16, rmacnak ...
4 years, 9 months ago (2016-03-22 17:02:44 UTC) #4
Florian Schneider
4 years, 9 months ago (2016-03-23 09:03:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ef1c7211bfab2303bc3aa2a825964ad60912d15e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698