VM: Use propagated type to improve checked smi operations in aot compiler.

runtime/vm/intermediate_language_arm64.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM64.
 #if defined(TARGET_ARCH_ARM64)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/compiler.h"
@@ skipping 2791 matching lines @@
 
 
 void CheckedSmiOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   CheckedSmiSlowPath* slow_path =
       new CheckedSmiSlowPath(this, compiler->CurrentTryIndex());
   compiler->AddSlowPathCode(slow_path);
   // Test operands if necessary.
   Register left = locs()->in(0).reg();
   Register right = locs()->in(1).reg();
   Register result = locs()->out(0).reg();
-  __ orr(result, left, Operand(right));
-  __ tsti(result, Immediate(kSmiTagMask));
+  intptr_t left_cid = this->left()->Type()->ToCid();
+  intptr_t right_cid = this->right()->Type()->ToCid();
+  bool combined_smi_check = false;
+  if (left_cid == kSmiCid) {

[rmacnak, 2016/03/22 16:46:16]

Missing same definition case.

[Florian Schneider, 2016/03/22 17:02:44]

Done here and for CheckEitherNonSmiInstr as well.

+    __ tsti(right, Immediate(kSmiTagMask));
+  } else if (right_cid == kSmiCid) {
+    __ tsti(left, Immediate(kSmiTagMask));
+  } else {
+    combined_smi_check = true;
+    __ orr(result, left, Operand(right));
+    __ tsti(result, Immediate(kSmiTagMask));
+  }
+
   __ b(slow_path->entry_label(), NE);
   switch (op_kind()) {
     case Token::kADD:
       __ adds(result, left, Operand(right));
       __ b(slow_path->entry_label(), VS);
       break;
     case Token::kSUB:
       __ subs(result, left, Operand(right));
       __ b(slow_path->entry_label(), VS);
       break;
     case Token::kBIT_OR:
-      // Operation part of combined smi check.
+      // Operation may be part of combined smi check.
+      if (!combined_smi_check) {
+        __ orr(result, left, Operand(right));
+      }
       break;
     case Token::kBIT_AND:
       __ and_(result, left, Operand(right));
       break;
     case Token::kBIT_XOR:
       __ eor(result, left, Operand(right));
       break;
     case Token::kEQ:
     case Token::kLT:
     case Token::kLTE:
@@ skipping 2835 matching lines @@
                                 1,
                                 locs());
   __ Drop(1);
   __ Pop(result);
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM64