chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java - Issue 182623003: ObserverList add/remove methods should return a boolean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

Issue 182623003: ObserverList add/remove methods should return a boolean. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen_orientation_listener

Patch Set: rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/javatests/src/org/chromium/base/ObserverListTest.java ('k') | content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

index e0bc518e42a977f2f66fd39f8d7532596ce03069..79af57a34d698a06e0bdf0c2e4551e629d514a97 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

@@ -173,8 +173,8 @@ public class TemplateUrlService {

public void registerLoadListener(LoadListener listener) {

ThreadUtils.assertOnUiThread();

- assert !mLoadListeners.hasObserver(listener);

- mLoadListeners.addObserver(listener);

+ boolean added = mLoadListeners.addObserver(listener);

+ assert added;

}

/**

@@ -183,8 +183,8 @@ public class TemplateUrlService {

public void unregisterLoadListener(LoadListener listener) {

ThreadUtils.assertOnUiThread();

- assert (mLoadListeners.hasObserver(listener));

- mLoadListeners.removeObserver(listener);

+ boolean removed = mLoadListeners.removeObserver(listener);

+ assert removed;

}

/**