Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: base/android/javatests/src/org/chromium/base/ObserverListTest.java

Issue 182623003: ObserverList add/remove methods should return a boolean. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen_orientation_listener
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/javatests/src/org/chromium/base/ObserverListTest.java
diff --git a/base/android/javatests/src/org/chromium/base/ObserverListTest.java b/base/android/javatests/src/org/chromium/base/ObserverListTest.java
index 19e8de70256a5b920f286015406935979bfffe11..cb09c2c60c0707142c610bb73676831cd7fbc07c 100644
--- a/base/android/javatests/src/org/chromium/base/ObserverListTest.java
+++ b/base/android/javatests/src/org/chromium/base/ObserverListTest.java
@@ -215,4 +215,35 @@ public class ObserverListTest extends InstrumentationTestCase {
assertTrue(it.hasNext());
assertTrue(15 == it.next());
}
+
+ @SmallTest
+ @Feature({"Android-AppBase"})
+ public void testAddObserverReturnValue() {
+ ObserverList<Object> observerList = new ObserverList<Object>();
+
+ Object a = new Object();
+ assertTrue(observerList.addObserver(a));
+ assertFalse(observerList.addObserver(a));
+
+ Object b = new Object();
+ assertTrue(observerList.addObserver(b));
+ assertFalse(observerList.addObserver(null));
+ }
+
+ @SmallTest
+ @Feature({"Android-AppBase"})
+ public void testRemoveObserverReturnValue() {
+ ObserverList<Object> observerList = new ObserverList<Object>();
+
+ Object a = new Object();
+ Object b = new Object();
+ observerList.addObserver(a);
+ observerList.addObserver(b);
+
+ assertTrue(observerList.removeObserver(a));
+ assertFalse(observerList.removeObserver(a));
+ assertFalse(observerList.removeObserver(new Object()));
+ assertTrue(observerList.removeObserver(b));
+ assertFalse(observerList.removeObserver(null));
+ }
}

Powered by Google App Engine
This is Rietveld 408576698