Remove media controls when not in use.

Source/core/html/shadow/MediaControlsAndroid.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 48 matching lines @@
 
 void MediaControlsAndroid::setMediaController(MediaControllerInterface* controller)
 {
     if (m_overlayPlayButton)
         m_overlayPlayButton->setMediaController(controller);
     if (m_overlayEnclosure)
         m_overlayEnclosure->setMediaController(controller);
     MediaControls::setMediaController(controller);
 }
 
+void MediaControlsAndroid::show()
+{
+    m_overlayPlayButton->setVisible(true);
+    m_overlayPlayButton->updateDisplayType();
+    MediaControls::show();
+}
+
+void MediaControlsAndroid::hide()
+{
+    m_overlayPlayButton->setVisible(false);
+    m_overlayPlayButton->updateDisplayType();

[acolwell GONE FROM CHROMIUM, 2014/03/06 19:21:54]

nit: It seems like you could unconditionally hide here instead.

[philipj_slow, 2014/03/18 04:14:13]

Yes, when moving this into MediaControls.cpp try just if (m_overlayEnclosure)
m_overlayEnclosure->hide().

+    MediaControls::hide();
+}
+
 void MediaControlsAndroid::playbackStarted()
 {
     m_overlayPlayButton->updateDisplayType();

[acolwell GONE FROM CHROMIUM, 2014/03/06 19:21:54]

It seems like you could make this call and the one below conditionally based on
whether m_panel->m_isDisplayed is true. This could be hidden behind a
MediaControls::isDisplayed() helper.

Doing this avoids the extra bool and allows updates only when the controls as a
whole are supposed to be displayed.

[Fredrik Öhrn, 2014/03/07 09:45:45]

Problem is that MediaControlOverlayPlayButtonElement::defaultEventHandler() can
also call updateDisplayType() on itself, there MediaControls::isDisplayed() is
not available since the buttons don't have a pointer back it.

     MediaControls::playbackStarted();
 }
 
 void MediaControlsAndroid::playbackStopped()
 {
     m_overlayPlayButton->updateDisplayType();
     MediaControls::playbackStopped();
 }
 
 void MediaControlsAndroid::insertTextTrackContainer(PassRefPtr<MediaControlTextTrackContainerElement> textTrackContainer)
 {
     // Insert it before the overlay play button so it always displays behind it.
     m_overlayEnclosure->insertBefore(textTrackContainer, m_overlayPlayButton);
 }
 }