Issue 18261008: PNaCl: Fix negative relocation addends on x86-32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18261008: PNaCl: Fix negative relocation addends on x86-32 (Closed)

Created:
7 years, 5 months ago by Mark Seaborn

Modified:
7 years, 5 months ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master

Visibility:
Public.

More Reviews

Description

PNaCl: Fix negative relocation addends on x86-32 Disable an assertion. This assertion made the behaviour on x86-32 inconsistent with x86-64 and ARM. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3548 TEST=*.ll tests + PNaCl toolchain trybots Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=af49991

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -0 lines)			Patch
M	lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	test/NaCl/ARM/negative-addend.ll	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A	test/NaCl/X86/negative-addend.ll	View	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

7 years, 5 months ago (2013-07-09 18:03:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as raf49991 (presubmit successful).

Expand Messages | Collapse Messages