Generated dart code should import transitive imports.

Generated dart code should import transitive imports.

R=rudominer@chromium.org, zra@google.com, jeffbrown, rudominer, tonyg
BUG=

Committed: https://chromium.googlesource.com/external/mojo/+/efaa264666331e56e6295a1ec3a51274cf941871

[tonyg, 2016-03-23 23:23:34]

Perhaps rollback my change and regenerate bindings along w/ this change?

[azani, 2016-03-23 23:31:04]

I checked and it does. The one thing you might not like is that importing all
the transitive imports, will generate unused import warnings. But we can always
address that later.

[azani, 2016-03-23 23:31:42]

azani@chromium.org changed reviewers:
+ ianloic@chromium.org

[azani, 2016-03-23 23:31:42]

Ian, I think this is of interest to you.

[rudominer, 2016-03-25 18:50:58]

rudominer@chromium.org changed reviewers:
+ zra@google.com

[rudominer, 2016-03-25 18:50:58]

Zach, can you help us out with some history here. Alex is fixing a problem that
.mojom.dart files do not have import statements for transitive imports in the
.mojom files. Are you aware of any history behind this? Do your recall if this
ever used to work?

[zra, 2016-03-25 19:43:43]

On 2016/03/25 18:50:58, rudominer wrote:
> Zach, can you help us out with some history here. Alex is fixing a problem
that
> .mojom.dart files do not have import statements for transitive imports in the
> .mojom files. Are you aware of any history behind this? Do your recall if this
> ever used to work?

It looks like this code hasn't been updated since it was copied from
mojo_js_generator.py many moons ago. Transitive imports has never worked for
Dart, and this is actually the first I've learned that it is expected to. I
would guess it's an artifact of C++ being the first target language. Hopefully
the extra lint errors aren't too annoying? I wonder if the TODO should be
addressed in this CL.

[azani, 2016-03-25 23:28:48]

ptal

[zra, 2016-03-28 15:37:16]

lgtm

If it's easy to do, could you also alphabetized the imports?

[rudominer, 2016-03-28 16:12:42]

lgtm. Please try to sync and re-generate and see if the changes to the
serialized_runtime_type_info goes away.

[ianloic, 2016-03-28 16:16:54]

ianloic@google.com changed reviewers:
+ ianloic@google.com

[ianloic, 2016-03-28 16:16:55]

It would be great to avoid unused imports. We're trying to keep them out of our
code so it would be great to keep them out of generated code.

It could be handy to warn about unused import in mojoms too when compiling.

[azani, 2016-03-28 20:22:18]

Description was changed from

==========
Generated dart code should import transitive imports.

R=jeffbrown, rudominer, tonyg
BUG=
==========

to

==========
Generated dart code should import transitive imports.

R=rudominer@chromium.org, zra@google.com, jeffbrown, rudominer, tonyg
BUG=

Committed:
https://chromium.googlesource.com/external/mojo/+/efaa264666331e56e6295a1ec3a...
==========

[azani, 2016-03-28 20:22:19]

Committed patchset #5 (id:80001) manually as
efaa264666331e56e6295a1ec3a51274cf941871 (presubmit successful).