Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: mojo/public/tools/bindings/generators/mojom_dart_generator.py

Issue 1826063002: Generated dart code should import transitive imports. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/generators/mojom_dart_generator.py
diff --git a/mojo/public/tools/bindings/generators/mojom_dart_generator.py b/mojo/public/tools/bindings/generators/mojom_dart_generator.py
index 59396d5018c84c4e44ed0df46063d689cde3b622..a3adb09401e71fb8c590199d5e0f04cb89eeb09d 100644
--- a/mojo/public/tools/bindings/generators/mojom_dart_generator.py
+++ b/mojo/public/tools/bindings/generators/mojom_dart_generator.py
@@ -601,8 +601,9 @@ class Generator(generator.Generator):
raise e
def GetImports(self, args):
+ used_imports = self.GetUsedImports(self.module)
used_names = set()
- for each_import in self.module.transitive_imports:
+ for each_import in used_imports.values():
simple_name = each_import["module_name"].split(".")[0]
# Since each import is assigned a library in Dart, they need to have
@@ -618,7 +619,7 @@ class Generator(generator.Generator):
counter += 1
each_import["rebased_path"] = GetImportUri(each_import['module'])
- return self.module.imports
+ return sorted(used_imports.values(), key=lambda x: x['rebased_path'])
def GetImportedInterfaces(self):
interface_to_import = {}

Powered by Google App Engine
This is Rietveld 408576698