Making check_initial_confidence verify return_code bisects.

scripts/slave/recipe_modules/auto_bisect/revision_state.py

Index: scripts/slave/recipe_modules/auto_bisect/revision_state.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/revision_state.py b/scripts/slave/recipe_modules/auto_bisect/revision_state.py
index bccb34af3fe837e7bf53d1d382b06bdad9447861..27e2411fdbedce480fb9786424e0c6b2a3feb96e 100644
--- a/scripts/slave/recipe_modules/auto_bisect/revision_state.py
+++ b/scripts/slave/recipe_modules/auto_bisect/revision_state.py
@@ -90,6 +90,7 @@ class RevisionState(object):
     self.build_url = self.bisector.get_platform_gs_prefix() + self._gs_suffix()
     self.values = []
     self.mean_value = None
+    self.overall_return_code = None
     self.std_dev = None
     self.repeat_count = MINIMUM_SAMPLE_SIZE
     self._test_config = None
@@ -330,8 +331,11 @@ class RevisionState(object):
     self.values += results['values']
     if self.bisector.is_return_code_mode():
       retcodes = test_results['retcodes']
-      overall_return_code = 0 if all(v == 0 for v in retcodes) else 1
-      self.mean_value = overall_return_code
+      self.overall_return_code = 0 if all(v == 0 for v in retcodes) else 1
+      # Keeping mean_value for compatibility with dashboard.
+      # TODO(robertocn): refactor mean_value, specially when uploading results
+      # to dashboard.

[qyearsley, 2016/03/23 22:09:36]

What do you think we should do specifically when uploading to the perf
dashboard? I see two main choices:

1. In Bisector._revision_data
(https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...),
send a field "value" or "overall_return_code" instead of "mean_value", and also
update the perf dashboard to deal with that. (I like this option a bit better)

2. In Bisector._revision_data, send either overall_return_code or mean_value,
but keep using the key "mean_value" so that the perf dashboard doesn't have to
be changed.

Do you agree?

+      self.mean_value = self.overall_return_code
     elif self.values:
       api = self.bisector.api
       self.mean_value = api.m.math_utils.mean(self.values)
@@ -508,7 +512,7 @@ class RevisionState(object):
     """
 
     if self.bisector.is_return_code_mode():
-      return self.mean_value == self.bisector.lkgr.mean_value
+      return self.overall_return_code == self.bisector.lkgr.overall_return_code
 
     while True:
       diff_from_good = self.bisector.significantly_different(
@@ -567,5 +571,9 @@ class RevisionState(object):
       next_revision_to_test.retest()
 
   def __repr__(self):
+    if self.overall_return_code is not None:
+      return ('RevisionState(rev=%s, values=%r, overall_return_code=%r, '
+              'std_dev=%r)') % (self.revision_string(), self.values,
+                                self.overall_return_code, self.std_dev)
     return ('RevisionState(rev=%s, values=%r, mean_value=%r, std_dev=%r)' % (
         self.revision_string(), self.values, self.mean_value, self.std_dev))