Making check_initial_confidence verify return_code bisects.

scripts/slave/recipe_modules/auto_bisect/bisector_test.py

Index: scripts/slave/recipe_modules/auto_bisect/bisector_test.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector_test.py b/scripts/slave/recipe_modules/auto_bisect/bisector_test.py
index ea7c53230a91b6761f44e83382d0f3cc2b2cb2ce..74da0ad8443b5ae491b4be2d5be5a64da00d7283 100755
--- a/scripts/slave/recipe_modules/auto_bisect/bisector_test.py
+++ b/scripts/slave/recipe_modules/auto_bisect/bisector_test.py
@@ -31,6 +31,7 @@ class MockRevisionClass(object):  # pragma: no cover
     self.previous_revision = None
     self.next_revision = None
     self.values = []
+    self.overall_return_code = None
     self.deps = {}
     self.status = ''
 
@@ -149,14 +150,29 @@ class BisectorTest(unittest.TestCase):  # pragma: no cover
 
   @mock.patch.object(auto_bisect.bisector.Bisector, 'significantly_different',
                      mock.MagicMock())
-  def test_check_initial_confidence_not_required(self):
+  def test_check_initial_confidence_return_code_pass(self):
     return_code_config = self.bisect_config
     return_code_config['test_type'] = 'return_code'
-    # When confidence is not required, confidence_score should not be called.
     bisector = auto_bisect.bisector.Bisector(self.dummy_api, return_code_config,
                                              MockRevisionClass)
+    bisector.good_rev.overall_return_code = 0
+    bisector.bad_rev.overall_return_code = 1
     self.assertTrue(bisector.check_initial_confidence())
-    self.assertFalse(bisector.significantly_different.called)
+
+  @mock.patch.object(auto_bisect.bisector.Bisector, 'significantly_different',
+                     mock.MagicMock())

[qyearsley, 2016/03/23 22:09:36]

There is no longer the line
self.assertFalse(bisector.significantly_different.called), so I believe that
this @mock.patch can be removed (same in
test_check_initial_confidence_return_code_pass)

+  def test_check_initial_confidence_return_code_fail(self):
+    return_code_config = self.bisect_config
+    return_code_config['test_type'] = 'return_code'
+    bisector = auto_bisect.bisector.Bisector(self.dummy_api, return_code_config,
+                                             MockRevisionClass)
+    bisector.good_rev.overall_return_code = 0
+    bisector.bad_rev.overall_return_code = 0
+    self.assertFalse(bisector.check_initial_confidence())
+
+    bisector.good_rev.overall_return_code = 1
+    bisector.bad_rev.overall_return_code = 1
+    self.assertFalse(bisector.check_initial_confidence())
 
 
 if __name__ == '__main__':