Logger: extract low level logging code into a separate class.

Current logger code is messy. It mixes together
four or even five different logging destinations.
I think we can extract the code related to a destination
into a separate class, do the same for the all destinations
and have four classes with more or less simple common logging
API

BUG=none
Meta-bug= https://code.google.com/p/chromium/issues/detail?id=260203

R=yangguo@chromium.org, yurys@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15664

[yurys, 2013-07-15 04:16:35]

I'd recommend you open a bug with a description of refactorings you are going to
apply to the logging and link corresponding CLs to it.

https://codereview.chromium.org/18259024/diff/4001/src/log.cc
File src/log.cc (right):

https://codereview.chromium.org/18259024/diff/4001/src/log.cc#newcode51
src/log.cc:51: public:
Consider moving this class and logic related to the correpoding log file into
its own file.

https://codereview.chromium.org/18259024/diff/4001/src/log.cc#newcode1814
src/log.cc:1814: if (strchr(FLAG_logfile, '%') != NULL ||
FLAG_logfile is passed as the parameter and read here from the flag. I think you
can drop the parameter.

https://codereview.chromium.org/18259024/diff/4001/src/log.cc#newcode1883
src/log.cc:1883: if (FLAG_ll_prof && Log::InitLogAtStart()) {
Log::InitLogAtStart() check is redundant.

https://codereview.chromium.org/18259024/diff/4001/src/log.cc#newcode1949
src/log.cc:1949: 
#undefine LL_LOG ?

[loislo, 2013-07-15 07:37:00]

https://codereview.chromium.org/18259024/diff/4001/src/log.cc
File src/log.cc (right):

https://codereview.chromium.org/18259024/diff/4001/src/log.cc#newcode51
src/log.cc:51: public:
On 2013/07/15 04:16:35, Yury Semikhatsky wrote:
> Consider moving this class and logic related to the correpoding log file into
> its own file.

I'd like to do that as a separate change.

https://codereview.chromium.org/18259024/diff/4001/src/log.cc#newcode1814
src/log.cc:1814: if (strchr(FLAG_logfile, '%') != NULL ||
On 2013/07/15 04:16:35, Yury Semikhatsky wrote:
> FLAG_logfile is passed as the parameter and read here from the flag. I think
you
> can drop the parameter.

FLAG_logfile was replaced with file_name

https://codereview.chromium.org/18259024/diff/4001/src/log.cc#newcode1883
src/log.cc:1883: if (FLAG_ll_prof && Log::InitLogAtStart()) {
On 2013/07/15 04:16:35, Yury Semikhatsky wrote:
> Log::InitLogAtStart() check is redundant.

Done.

https://codereview.chromium.org/18259024/diff/4001/src/log.cc#newcode1949
src/log.cc:1949: 
On 2013/07/15 04:16:35, Yury Semikhatsky wrote:
> #undefine LL_LOG ?

I see no reasons to do that because it gives us no benefits.

[yurys, 2013-07-15 09:36:44]

lgtm

[Yang, 2013-07-15 11:34:57]

On 2013/07/15 09:36:44, Yury Semikhatsky wrote:
> lgtm

lgtm.

[loislo, 2013-07-15 11:35:49]

Committed patchset #4 manually as r15664 (presubmit successful).