Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: src/log.h

Issue 18259024: Logger: extract low level logging code into a separate class. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comments addressed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.h
diff --git a/src/log.h b/src/log.h
index 07ecd0efe768da86efeb4159333a008da8ac926c..bb3dbd5956e10594300899874714b128f0215bb8 100644
--- a/src/log.h
+++ b/src/log.h
@@ -151,6 +151,7 @@ class CompilationInfo;
// original tags when writing to the log.
+class LowLevelLogger;
class Sampler;
@@ -430,30 +431,8 @@ class Logger {
// Appends symbol for the name.
void AppendSymbolName(LogMessageBuilder*, Symbol*);
- // Emits general information about generated code.
- void LogCodeInfo();
-
void RegisterSnapshotCodeName(Code* code, const char* name, int name_size);
- // Low-level logging support.
-
- void LowLevelCodeCreateEvent(Code* code, const char* name, int name_size);
-
- void LowLevelCodeMoveEvent(Address from, Address to);
-
- void LowLevelCodeDeleteEvent(Address from);
-
- void LowLevelSnapshotPositionEvent(Address addr, int pos);
-
- void LowLevelLogWriteBytes(const char* bytes, int size);
-
- template <typename T>
- void LowLevelLogWriteStruct(const T& s) {
- char tag = T::kTag;
- LowLevelLogWriteBytes(reinterpret_cast<const char*>(&tag), sizeof(tag));
- LowLevelLogWriteBytes(reinterpret_cast<const char*>(&s), sizeof(s));
- }
-
// Emits a profiler tick event. Used by the profiler thread.
void TickEvent(TickSample* sample, bool overflow);
@@ -495,6 +474,7 @@ class Logger {
int cpu_profiler_nesting_;
Log* log_;
+ LowLevelLogger* ll_logger_;
NameBuffer* name_buffer_;
« no previous file with comments | « no previous file | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698