Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1825653002: Mojom frontend: Correctly handle empty structs in computeVersionInfo() (Closed)

Created:
4 years, 9 months ago by rudominer
Modified:
4 years, 9 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom frontend: Correctly handle empty structs in computeVersionInfo() When a struct has no fields, it's version_info should still have a version zero with num_bytes=8. There was a bug where instead we had num_bytes=0 in this case. This patch fixes that bug and adds a test case. BUG=#173 R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e72c5b36e0633399dfe0f906be25cdf0fc0935be

Patch Set 1 #

Patch Set 2 : Rebase and regenerate sha1s. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -15 lines) Patch
M mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/math/math_calculator.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_structs.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_unions.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/validation_test_interfaces.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_factory.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_interfaces.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/mojom/computed_data.go View 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/serialization/serialization_test.go View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rudominer
ptal
4 years, 9 months ago (2016-03-22 21:32:27 UTC) #3
azani
lgtm
4 years, 9 months ago (2016-03-22 23:49:32 UTC) #4
rudominer
4 years, 9 months ago (2016-03-22 23:57:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e72c5b36e0633399dfe0f906be25cdf0fc0935be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698