mojom/mojom_parser/mojom/computed_data.go - Issue 1825653002: Mojom frontend: Correctly handle empty structs in computeVersionInfo()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/mojom_parser/mojom/computed_data.go

Issue 1825653002: Mojom frontend: Correctly handle empty structs in computeVersionInfo() (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Rebase and regenerate sha1s. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 ('k') | mojom/mojom_parser/serialization/serialization_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojom/mojom_parser/mojom/computed_data.go

diff --git a/mojom/mojom_parser/mojom/computed_data.go b/mojom/mojom_parser/mojom/computed_data.go

index e0a3438666b90e092616db8f82d78a5110d068d3..fc70091bb5de0c1e17b51c1700ee98df056fa274 100644

--- a/mojom/mojom_parser/mojom/computed_data.go

+++ b/mojom/mojom_parser/mojom/computed_data.go

@@ -201,7 +201,7 @@ func (e *StructFieldMinVersionError) Error() string {

func (s *MojomStruct) computeVersionInfo() error {

s.versionInfo = make([]StructVersion, 0)

previousMinVersion := uint32(0)

- payloadSizeSoFar := uint32(0)

+ payloadSizeSoFar := structHeaderSize

for i, field := range s.fieldsInOrdinalOrder {

value, literalValue, found, ok := field.minVersionAttribute()

if found == false {