Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1825593002: GrVkGpu initialization cleanup. (Closed)

Created:
4 years, 9 months ago by jvanverth1
Modified:
4 years, 9 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GrVkGpu initialization cleanup. Add GrVkBackendContext for GrVkGpu initialization Add missing extension initialization Use device function pointers rather than instance BUG=skia:5116 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825593002 Committed: https://skia.googlesource.com/skia/+/633b35657c964c32e7010b14bb2d396b4a764c52

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address comments (and rebase to ToT) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+644 lines, -428 lines) Patch
M gyp/gpu.gypi View 1 chunk +3 lines, -1 line 0 comments Download
A include/gpu/vk/GrVkBackendContext.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
M include/gpu/vk/GrVkInterface.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrContextFactory.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/GrGpuFactory.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLUniformHandler.h View 1 chunk +2 lines, -2 lines 0 comments Download
A src/gpu/vk/GrVkBackendContext.cpp View 1 chunk +252 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkExtensions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/vk/GrVkExtensions.cpp View 2 chunks +131 lines, -7 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 4 chunks +23 lines, -18 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 4 chunks +48 lines, -266 lines 0 comments Download
M src/gpu/vk/GrVkInterface.cpp View 4 chunks +129 lines, -126 lines 0 comments Download
M src/gpu/vk/GrVkUniformHandler.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
jvanverth1
4 years, 9 months ago (2016-03-22 20:08:02 UTC) #3
jvanverth1
In looking at this further, I realized that the extension setup is not quite correct: ...
4 years, 9 months ago (2016-03-23 13:54:32 UTC) #5
egdaniel
https://codereview.chromium.org/1825593002/diff/1/include/gpu/vk/GrVkBackendContext.h File include/gpu/vk/GrVkBackendContext.h (right): https://codereview.chromium.org/1825593002/diff/1/include/gpu/vk/GrVkBackendContext.h#newcode25 include/gpu/vk/GrVkBackendContext.h:25: struct GrVkBackendContext : public SkRefCnt { Does the comment ...
4 years, 9 months ago (2016-03-23 14:51:57 UTC) #6
jvanverth1
https://codereview.chromium.org/1825593002/diff/1/include/gpu/vk/GrVkBackendContext.h File include/gpu/vk/GrVkBackendContext.h (right): https://codereview.chromium.org/1825593002/diff/1/include/gpu/vk/GrVkBackendContext.h#newcode25 include/gpu/vk/GrVkBackendContext.h:25: struct GrVkBackendContext : public SkRefCnt { On 2016/03/23 14:51:57, ...
4 years, 9 months ago (2016-03-23 15:44:13 UTC) #7
egdaniel
lgtm. not sure if Brian has any comments based on the work he is doing
4 years, 9 months ago (2016-03-23 17:04:29 UTC) #8
bsalomon
On 2016/03/23 17:04:29, egdaniel wrote: > lgtm. not sure if Brian has any comments based ...
4 years, 9 months ago (2016-03-23 17:22:45 UTC) #9
jvanverth1
On 2016/03/23 17:22:45, bsalomon wrote: > On 2016/03/23 17:04:29, egdaniel wrote: > > lgtm. not ...
4 years, 9 months ago (2016-03-23 17:38:39 UTC) #10
bsalomon
On 2016/03/23 17:38:39, jvanverth1 wrote: > On 2016/03/23 17:22:45, bsalomon wrote: > > On 2016/03/23 ...
4 years, 9 months ago (2016-03-23 17:39:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825593002/20001
4 years, 9 months ago (2016-03-23 17:42:59 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 18:01:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/633b35657c964c32e7010b14bb2d396b4a764c52

Powered by Google App Engine
This is Rietveld 408576698