Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 182553004: Make git non-interactive when checking for src-internal access (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Ryan Sleevi
Visibility:
Public.

Description

Make git non-interactive when checking for src-internal access git sometimes blocks asking for a password. On a random machine that didn't know anything about google/chromium, it failed immediately with "fatal: could not read Username for 'https://chrome-internal.googlesource.com': No such file or directory" but on my real machine w/o _netrc it blocks and wants this: Username for 'https://chrome-internal.googlesource.com': Password for 'https://chrome-internal.googlesource.com': There's no --non-interactive unfortunately, it's supposed to magically decide if it's connected to a tty and behave appropriately. It does not, perhaps because of being wrapped in depot_tools .bat files, perhaps an msysgit-port bug, perhaps being called from python. Anyway https://github.com/bower/bower/issues/1009 had a magic incantation that works for this case: 'true' is available in the msys distribution. R=iannucci@chromium.org BUG=323300 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=253844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
6 years, 10 months ago (2014-02-27 05:40:51 UTC) #1
iannucci
lgtm
6 years, 10 months ago (2014-02-27 08:58:39 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 9 months ago (2014-02-27 16:57:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/182553004/1
6 years, 9 months ago (2014-02-27 16:58:01 UTC) #4
commit-bot: I haz the power
Change committed as 253844
6 years, 9 months ago (2014-02-27 17:00:18 UTC) #5
Nico
(re CL description: I believe setting usepty = 0 in buildbot.tac on that bot would've ...
6 years, 9 months ago (2014-03-05 00:58:35 UTC) #6
scottmg
6 years, 9 months ago (2014-03-05 02:52:46 UTC) #7
Message was sent while issue was closed.
On 2014/03/05 00:58:35, Nico wrote:
> (re CL description: I believe setting usepty = 0 in buildbot.tac on that bot
> would've fixed this too)

It wasn't on a bot, was someone on #chromium having trouble.

Powered by Google App Engine
This is Rietveld 408576698