win_toolchain/get_toolchain_if_necessary.py - Issue 182553004: Make git non-interactive when checking for src-internal access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win_toolchain/get_toolchain_if_necessary.py

Issue 182553004: Make git non-interactive when checking for src-internal access (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win_toolchain/get_toolchain_if_necessary.py

diff --git a/win_toolchain/get_toolchain_if_necessary.py b/win_toolchain/get_toolchain_if_necessary.py

index 033c091018fb3e25bd9084b180403d2d76e138fa..266806b0699004c07c5ae74de38f8fd4d37e3ded 100755

--- a/win_toolchain/get_toolchain_if_necessary.py

+++ b/win_toolchain/get_toolchain_if_necessary.py

@@ -126,7 +126,7 @@ def HaveSrcInternalAccess():

shell=True, stdin=nul, stdout=nul, stderr=nul) == 0:

return True

return subprocess.call(

- ['git', 'remote', 'show',

+ ['git', '-c', 'core.askpass=true', 'remote', 'show',

'https://chrome-internal.googlesource.com/chrome/src-internal/'],

shell=True, stdin=nul, stdout=nul, stderr=nul) == 0

« no previous file with comments | « no previous file | no next file » | no next file with comments »